fix: prevent prematurely triggered Japanese label creation

[gijigae]

Description

The changes ensure that the Enter key press during Japanese IME composition will not prematurely trigger label creation.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

Screenshots and Media (if applicable)

Before the change, the Enter key prematurely created a label, "安全なう上の". With the change in place, an intended label, "安全なう上の監査", was successfully created.

Test Scenarios

Confirmed intended Japanese labels are successfully generated with the change. Also, verified the change does not affect the existing workflow for English label creation.

References

#7022

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of the Enter key in dropdowns and label creation fields to prevent unintended actions while using Input Method Editors (IME) for complex character input. This ensures that actions like opening dropdowns or creating labels are not triggered prematurely during text composition.

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

Walkthrough

The changes update keydown event handlers across several components and hooks to check for IME (Input Method Editor) composition state before processing "Enter" key actions. This ensures that actions like opening dropdowns or creating labels are not triggered prematurely while the user is composing text, particularly with complex character input.

Changes

Files	Change Summary
packages/ui/src/hooks/use-dropdown-key-down.tsx web/core/hooks/use-dropdown-key-down.tsx	Modified keydown handlers to ignore "Enter" key events if the event is in IME composition (!event.nativeEvent.isComposing).
web/core/components/issues/issue-detail/label/select/label-select.tsx web/core/components/issues/issue-layouts/properties/label-dropdown.tsx	Updated Enter key handling in label creation inputs to prevent action during IME composition.

Poem

A rabbit hops with nimble grace,
Ensuring keys don’t run the race—
While humans type with IME flair,
No dropdowns open, no labels snare.
Only when the words are done,
Does the magic truly run!
🐇⌨️✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between cfac8ce and b2b0e9e.

📒 Files selected for processing (4)

• packages/ui/src/hooks/use-dropdown-key-down.tsx (1 hunks)
• web/core/components/issues/issue-detail/label/select/label-select.tsx (1 hunks)
• web/core/components/issues/issue-layouts/properties/label-dropdown.tsx (1 hunks)
• web/core/hooks/use-dropdown-key-down.tsx (1 hunks)

🔇 Additional comments (4)

web/core/components/issues/issue-detail/label/select/label-select.tsx (1)

102-102: Good fix for Japanese IME input handling

Adding the !e.nativeEvent.isComposing check prevents premature label creation when users are still composing text with the Japanese IME. This correctly addresses the issue described in PR #7084 where pressing Enter during composition would create incomplete labels.

web/core/components/issues/issue-layouts/properties/label-dropdown.tsx (1)

161-161: Good IME composition check

Adding the !e.nativeEvent.isComposing check ensures that pressing Enter during Japanese text composition doesn't prematurely trigger label creation. This change is consistent with the modification in label-select.tsx and addresses the same issue.

web/core/hooks/use-dropdown-key-down.tsx (1)

24-24: Consistent IME handling in dropdown hook

Adding the !event.nativeEvent.isComposing check here ensures that all components using this hook will correctly handle IME composition events. This is a good centralized fix that prevents Enter key actions from firing prematurely during text composition.

packages/ui/src/hooks/use-dropdown-key-down.tsx (1)

15-15: Good IME handling in shared UI hook

Adding the !event.nativeEvent.isComposing check ensures proper handling of IME composition across all components using this shared hook. This change completes the set of modifications needed to fix the Japanese input issue consistently throughout the application.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.