Bugfix: do not generate invalid JSON when float value is +Inf, -Inf or NaN #421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves issue #134 - Invalid JSON generated for NaN and Inf.
Context:
The following code generates invalid JSON, which cannot be unmarshalled either via easyjson or builtin go encoding/json package.
Output:
Suggested solution:
In
jwriter/writer.go
: check floats for NaN, +Inf, -Inf values before passing them intostrconv.AppendFloat
, and writew.Error = "json: unsupported value: ..."
if it is so