Skip to content

magento/magento2#39640: Issue with the Customizable Options grid on the product page in the admin panel #39694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: 2.4-develop
Choose a base branch
from
Open

magento/magento2#39640: Issue with the Customizable Options grid on the product page in the admin panel #39694

wants to merge 27 commits into from

Conversation

pavel77718
Copy link
Contributor

Description (*)

As the author of the issue wrote, the problem is that when adding a new option in excess of the configured amount, the interface switches to the second page, but the new value is not added—the page remains in a constant loading state.

Fixed Issues (if relevant)

  1. Fixes Issue with the Customizable Options grid on the product page in the admin panel #39640

Manual testing scenarios (*)

  1. Go to the product page.
  2. Create a Customizable Option with the drop-down type.
  3. Add new values until both pages are fully populated.
  4. Save the product.
  5. Navigate to the Customizable Options tab.
  6. Add a new value.

Expected result

The interface switches to the third page with the new value.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

pavel77718 and others added 4 commits February 28, 2025 14:43
@pavel77718
magento#39481: Completely removing a gallery-image from be keeps scop…
596503a 
…e roles/types set (base/small/thumbnail) and after re-adding "old" roles/types appear

- fixed issue with "old" roles/types after re-adding images
@pavel77718
magento#39481: Completely removing a gallery-image from be keeps scop…
baf8e32 
…e roles/types set (base/small/thumbnail) and after re-adding "old" roles/types appear

- changed copyright
@pavel77718
Merge branch '2.4-develop' into 2.4-develop
7be854d
@pavel77718
magento#39640: Completely removing a gallery-image from be keeps scop…
8b59433 
…e roles/types set (base/small/thumbnail) and after re-adding "old" roles/types appear

- rolled back a file that was changed by mistake for another issue
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Mar 3, 2025

Hi @pavel77718. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Perspective partners-contribution Pull Request is created by Magento Partner labels Mar 3, 2025
@pavel77718
Copy link
Contributor Author

@magento run all tests

1 similar comment
@pavel77718
Copy link
Contributor Author

@magento run all tests

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 4, 2025
@pavel77718
Copy link
Contributor Author

@magento run all tests

@pavel77718
Copy link
Contributor Author

@magento run all tests

@pavel77718
Copy link
Contributor Author

@magento run Functional Tests B2B, Functional Tests EE, Integration Tests

@pavel77718
Copy link
Contributor Author

@magento run Integration Tests

@pavel77718
Copy link
Contributor Author

@magento run all tests

@pavel77718
Copy link
Contributor Author

@magento run all tests

@pavel77718
Copy link
Contributor Author

@magento run Database Compare, Functional Tests B2B, Functional EE, WebAPI Tests

@pavel77718
Copy link
Contributor Author

@magento run Functional Tests EE

@pavel77718
Copy link
Contributor Author

@magento run all tests

@pavel77718
Copy link
Contributor Author

@magento run Functional Tests B2B, Functional Tests EE

@pavel77718
Copy link
Contributor Author

@magento run all tests

@pavel77718
Copy link
Contributor Author

@magento run Functional Tests B2B, Functional Tests EE

@pavel77718
Copy link
Contributor Author

I haven't started working on the tests. You can take care of that.

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Static Tests, Unit Tests, Functional Tests B2B, Functional Tests EE

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

Hello @engcom-Hotel,

I have added the jasmine tests for the fix. Also , I feel that the failing test cases are not related to the PR changes. Could you please review it ? Moving this PR to pending review.

Thanks!

@engcom-Dash engcom-Dash moved this from Changes Requested to Pending Review in Community Dashboard May 14, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Pending Review to Review in Progress in Community Dashboard May 14, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Review in Progress to Ready for Testing in Community Dashboard May 15, 2025
@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in Community Dashboard May 15, 2025
@engcom-Bravo
Copy link
Contributor

Hi @pavel77718,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • Go to the product page.
  • Create a Customizable Option with the drop-down type.
  • Add new values until both pages are fully populated.
  • Save the product.
  • Navigate to the Customizable Options tab.
  • Add a new value.

Before: ✖️ 

Screen.Recording.2025-05-15.at.11.36.13.am.mov

After: ✔️

Screen.Recording.2025-05-15.at.2.32.14.pm.mov

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended testing (optional) in Community Dashboard May 15, 2025
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests B2B, Static Tests

@engcom-Dash
Copy link
Contributor

engcom-Dash commented May 16, 2025 •
edited
Loading

The consistent failure in Functional B2B is not related to the PR changes and it is a known issue. The other failure is inconsistent. They neither part of the PR nor failing because of the PR changes.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39694/b9fb336e413ec1f099994c29d2fa5bb2/Functional/allure-report-b2b/index.html#categories/8f0831c1d06562890f5ec21062dae309/c697e0409abfe9f8/

image

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39694/c4347804b8cd14e8d042caeb57d833ec/Functional/allure-report-b2b/index.html#categories/8f0831c1d06562890f5ec21062dae309/6199b12ab001d804/

image

Known issue: StoreFrontSimpleProductWithSpecialAndTierDiscountPriceTest https://jira.corp.adobe.com/browse/ACQE-7971

Static Test Failure

The consistent static test failures are not because of this code changes done in this PR. It is a known issue and has JIRA Opened for the same.

Known Issue:
"use strict" is unnecessary inside of modules: https://jira.corp.adobe.com/browse/AC-14517.

Hence moving this PR in Merge In Progress.

@engcom-Dash engcom-Dash moved this from Extended testing (optional) to Pending Approval in Community Dashboard May 16, 2025
@engcom-Dash engcom-Dash moved this from Pending Approval to Merge in Progress in Community Dashboard Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel approved these changes

Assignees

@engcom-Dash engcom-Dash

Labels
Partner: Perspective partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Project: Community Picked PRs upvoted by the community
Projects
Community Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with the Customizable Options grid on the product page in the admin panel
6 participants
@pavel77718 @engcom-Hotel @engcom-Dash @engcom-Bravo @engcom-Charlie @m2-github-services