-
Notifications
You must be signed in to change notification settings - Fork 9.4k
#39604 Fixed rendering products list after applying filters #39686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Preserve previously applied filters for Ajax request
|
Hi @sydor-dev. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
|
@magento run all tests |
1 similar comment
|
@magento run all tests |
|
Failed to run the builds. Please try to re-run them later. |
|
@magento create issue |
|
@magento run all tests |
|
@magento run all tests |
|
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @sydor-dev,
Thanks for the contribution!
Please look into the functional tests failures, it seems they are failing due to code changes.
Thanks
|
@magento run Functional Tests CE |
|
@magento run all tests |
|
Hello @sydor-dev did you get a chance to look into the functional tests failures ? Thanks! |
|
@magento run all tests |
|
Hi @sydor-dev , I hope you're doing well. I wanted to check the current status of this PR. It’s been over a month since the last update, and we’ve noticed that because of this fix many other functionalities are breaking. If you're still planning to work on it, please let us know your plan. For now we are marking this PR as draft and moving it to On Hold. Otherwise, we may need to close the PR for now. You can reopen it anytime when you're ready to continue. Thanks for your contributions! |
|
@magento run Functional Tests CE |
|
@magento run Functional Tests B2B |
|
Hi @sydor-dev Gentle Reminder for this PR. |
|
@magento run Functional Tests CE Functional Tests EE Functional Tests B2B |
|
Failed to run the builds. Please try to re-run them later. |
|
@magento run "Functional Tests CE" "Functional Tests EE" "Functional Tests B2B" |
|
Failed to run the builds. Please try to re-run them later. |
|
@magento run all tests |
|
@Megento run all tests |
|
Hello @sydor-dev, The correct command to run tests is as follows: @magento run all tests |
|
Hello @sydor-dev, It appears that some automated tests are still failing. We kindly request you to fix these issues so that we can proceed with further processing. Thank you. |
|
Hello @sydor-dev, We appreciate your contribution! Since we haven't received a response from you for an extended period, we are closing this PR for now. Whenever you're ready to resume work on this, please feel free to reopen it or request us to do so. We'll be more than happy to assist you. Thanks once again! |
Description (*)
The issue occures after Ajax request to
After doing all steps to reproduce Request Payload contains

paging[notLimits]: 1and no other limits. It means that BackEnd shoud return all Products excluding selectedFilters should be preserved to prevent overloading

Manual testing scenarios (*)
Important: 1 or more products should be unselected
Expected result
Selected Products added in amount of 58 items. Request completed
Actual result
No products added. Page freezes
Contribution checklist (*)
Resolved issues: