Skip to content

Add 'Open' event on modal component #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

mat02
Copy link
Contributor

@mat02 mat02 commented Sep 2, 2024

Proposed changes

Fixes #978 #1104 by adding event handler to Modal component, so actions can be performed after Modal dialog is shown.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

This is pretty minor change in the code. As this is my first contribution directly to the codebase I am not sure if this requires some additional changes. I've used antd 'afterOpenChange' event handler to implement this, which has a sideeffect that it only starts after the modal is rendered, but I think this is not an issue in most cases.

Sorry, something went wrong.

Copy link

netlify bot commented Sep 2, 2024

👷 Deploy request for lowcoder-test pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit d988695

@mat02 mat02 marked this pull request as ready for review September 2, 2024 08:45
@mat02 mat02 mentioned this pull request Sep 2, 2024
8 tasks
@ludomikula
Copy link
Collaborator

Thank you!

@ludomikula ludomikula merged commit 5c4c13f into lowcoder-org:dev Sep 2, 2024
3 checks passed
@mat02 mat02 deleted the feat-modal-open-event branch September 2, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants