QuickAction was adapted to HD-screens.#18
Open
mksmbrtsh wants to merge 3 commits intolorensiuswlt:masterfrom
Open
QuickAction was adapted to HD-screens.#18mksmbrtsh wants to merge 3 commits intolorensiuswlt:masterfrom
mksmbrtsh wants to merge 3 commits intolorensiuswlt:masterfrom
Conversation
QuickAction was adapted to HD-screens.
|
I tried using your changes, and while the arrow shows up, it seems to cut my action bar in half. will play around with it some to see if i can fix it Edit: Fixed by changing your PopupWindows.java to say the following: This causes my actionbar with 3 items to render correctly on an HTC one with 1920x1080 screen. 450 was too small. Edit: this still doesn't work as when I run it on the emulator with an 800x480 screen it shifts left. anyone know the fix? |
ghost
approved these changes
May 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, i fixs bug in shown QuickAction at larges screens.
QuickAction correctly shown at small screens, her width is width of screen.
And QuickActtion correctly shown at large screen, and her width value is MAX_WIDTH_POPUP_WINDOWS constant. Arrow shown is correctly, too.