Skip to content

Conversation

@neznaika0
Copy link
Contributor

@neznaika0 neznaika0 commented Sep 4, 2024

Sorry, for one PR. It's easier to apply the changes this way. The excess can be returned to its original state.

these are general fixes that are found after a clean installation and exemplary user behavior.

  • fix: Add id for HTMX action
    "Edit Thread" button does not work
  • fix: Add LEFT JOIN instead of JOIN
    If there are no Categories or Threads/Posts inside, the list of Categories is empty. It should be displayed regardless of Trends/Posts
  • fix: Add URL for home page
    Clicking on the Logo/Sitename does not lead anywhere. Annoy
  • fix: Сase when no categories
    If there are no categories in the database, exceptions will occur. You need to add empty arrays by default
  • fix: Configure cache handler
    The initial setup does not provide for the use of a Cache. Corrected .env
  • fix: Delete unnecessary namespaces
  • fix: Bad encoding DOMDocument
    The texts were displayed incorrectly after formatting. See https://www.php.net/manual/en/domdocument.loadhtml.php#74777
    EDIT: HTML-ENTITIES will be deprecated. See https://www.php.net/manual/en/function.mb-convert-encoding.php#127529
  • Hide pagination if total pages = 1

@neznaika0 neznaika0 force-pushed the fix-after-clean-install branch from ec7d74c to 60ea4f4 Compare September 4, 2024 14:28
@neznaika0
Copy link
Contributor Author

Why is the cache permanent?

cache()->save($cacheKey, $permissions, 0);

@lonnieezell
Copy link
Owner

Why is the cache permanent?

cache()->save($cacheKey, $permissions, 0);

Without digging back through the code, I would assume it's because they don't change often. You would destroy the cache only when permissions change.

@neznaika0
Copy link
Contributor Author

Okay. I've already forgotten what I was trying to fix, too. I think it's worth testing and checking the PR again.

@neznaika0 neznaika0 requested a review from lonnieezell March 10, 2025 14:48
@neznaika0 neznaika0 marked this pull request as ready for review March 10, 2025 14:49
@neznaika0
Copy link
Contributor Author

The error appears sometimes. I don't think you should look at her right now.
I ran on PHP 8.4 and there are a lot of errors. And CI v4.6 already requires a lot of fixes.

Interest is lost. I hope someone will continue to develop 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants