toggle: Add segmented style to ToggleGroup#2275
Merged
huacnlee merged 6 commits intolongbridge:mainfrom Apr 23, 2026
Merged
Conversation
huacnlee
changed the title
huacnlee
changed the title
segmented style to ToggleGroup
huacnlee
changed the title
segmented style to ToggleGroupsegmented style to ToggleGroup
huacnlee
previously approved these changes
Apr 22, 2026
6 tasks
huacnlee
force-pushed
the
issue-2272-segmented-toggle-group
branch
from
67b7f5f to
26eb8ac
Compare
AzureZee
pushed a commit
to AzureZee/gpui-component
that referenced
this pull request
Apr 23, 2026
Closes longbridge#2272 ## Description Adds an opt-in segmented style for `ToggleGroup`, with configurable spacing. This lets `ToggleGroup` render connected toggle items with shared outline borders and only outer rounded corners, while preserving the existing separated default style and the current `Vec<bool>` multi-toggle callback behavior. It also adds story and documentation coverage for the new API. AI assistance was used to draft and implement this change; the code was reviewed against the existing `ButtonGroup`/`ToggleGroup` patterns and validated locally. ## Screenshot | Before | After | | ------ | ----- | | | <img width="2930" height="1900" alt="Segmented ToggleGroup story after" src="https://github.com/user-attachments/assets/12bd4ae0-62e7-4e24-83c2-90bef2fe5884" /> | ## How to Test - `cargo test -p gpui-component test_toggle_group_builder` - `cargo run` ## Checklist - [x] I have read the [CONTRIBUTING](../CONTRIBUTING.md) document and followed the guidelines. - [x] Reviewed the changes in this PR and confirmed AI generated code (If any) is accurate. - [x] Passed `cargo run` for story tests related to the changes. - [x] Tested macOS, Windows and Linux platforms performance (if the change is platform-specific; this change is not platform-specific) --------- Co-authored-by: Jason Lee <huacnlee@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2272
Description
Adds an opt-in segmented style for
ToggleGroup, with configurable spacing.This lets
ToggleGrouprender connected toggle items with shared outline borders and only outer rounded corners, while preserving the existing separated default style and the currentVec<bool>multi-toggle callback behavior. It also adds story and documentation coverage for the new API.AI assistance was used to draft and implement this change; the code was reviewed against the existing
ButtonGroup/ToggleGrouppatterns and validated locally.Screenshot
How to Test
cargo test -p gpui-component test_toggle_group_buildercargo runChecklist
cargo runfor story tests related to the changes.