fix(text): compute is_last per-block in non-scrollable render path#2093
Open
sassman wants to merge 1 commit intolongbridge:mainfrom
Open
fix(text): compute is_last per-block in non-scrollable render path#2093sassman wants to merge 1 commit intolongbridge:mainfrom
sassman wants to merge 1 commit intolongbridge:mainfrom
Conversation
All blocks were given is_last=true via a shared NodeRenderOptions, causing every block's margin-bottom to resolve to rems(0). Paragraph spacing set via TextViewStyle::paragraph_gap had no visible effect. Mirror the virtualized-list path: compute is_last per block so only the final block gets zero bottom spacing. Signed-off-by: Sven Kanoldt <sven@d34dl0ck.me>
Member
|
Please upload a screenshot to show me the before/after change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2092.
In
ParsedDocument::render_root, the non-scrollable path passedis_last: trueto every block via a sharedNodeRenderOptions.Since
render_blocksetsmb = rems(0.)whenis_last, no block ever received a bottom margin — makingparagraph_gap, heading spacing, and---divider spacing invisible.Fix: compute
is_lastper-block (matching what the virtualized-list path already does).