Skip to content

Hotkeys change editable #7962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 79 commits into
base: main
Choose a base branch
from

Conversation

1oca1h0st
Copy link
Contributor

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

变更全局展示APP的快捷键command+e,避免与本地的其他热键冲突

📝 补充信息 | Additional Information

1oca1h0st and others added 30 commits February 20, 2025 17:53
refine role assignment logic for specific Azure OpenAI models & Azure…
lobehubbot and others added 22 commits May 12, 2025 02:49
Change attr for SowApp
Copy link

vercel bot commented May 25, 2025

@1oca1h0st is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 25, 2025
@lobehubbot
Copy link
Member

👍 @1oca1h0st

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

@dosubot dosubot bot added the 🌠 Feature Request New feature or request | 特性与建议 label May 25, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Makes the global ShowApp hotkey (Mod+E) user-editable by removing the nonEditable property in src/const/hotkeys.ts, allowing users to customize it to avoid conflicts with other local hotkeys.

  • Removed nonEditable: true from the ShowApp hotkey configuration in src/const/hotkeys.ts while maintaining its Essential group and global scope settings

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

codecov bot commented May 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.47%. Comparing base (b4b426f) to head (ce7ed8e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7962      +/-   ##
==========================================
- Coverage   88.47%   88.47%   -0.01%     
==========================================
  Files         821      821              
  Lines       60274    60273       -1     
  Branches     5496     5696     +200     
==========================================
- Hits        53325    53324       -1     
  Misses       6949     6949              
Flag Coverage Δ
app 88.47% <ø> (-0.01%) ⬇️
server 95.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arvinxx
Copy link
Contributor

arvinxx commented May 25, 2025

单纯这样没用的,得支持 electron 端快捷键的重新注册,我今天搞一下吧

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


It's useless simply, so I have to support the re-registration of shortcut keys on the electron side. I'll do it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌠 Feature Request New feature or request | 特性与建议 size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants