Fix linking of static archives with GCC with LTO #301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you try to build llvm-test-suite with GCC and LTO, the MicroBenchmarks will fail to link.
Digging through the logs you'll find a warning earlier on:
This is caused by CMake creating the library with ar and not gcc-ar, even though CMake finds gcc-ar:
The fix is to set CMAKE_INTERPROCEDURAL_OPTIMIZATION which gets CMake to properly use the right ar/ranlib/etc. when using LTO.
We can set this in the cmake/caches/*LTO.cmake presets instead of manually adding the -flto flag which fixes the link error.
Unfortunately, CMake also sets -flto=thin for whatever reason on Clang. There's no way to configure it to do fat LTO, and there's a ton of open issues about this upstream: https://gitlab.kitware.com/cmake/cmake/-/issues/23136
It seems like the best way to workaround this is to just append -flto=auto in CXXFLAGS/LDFLAGS for Clang.