Skip to content

Create symlink for llvm-link in libc docker image #210929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jinge90 merged 6 commits into from
Jul 24, 2026
+3 −2
Merged

Create symlink for llvm-link in libc docker image #210929

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f589cc
Install llvm 23 in libc docker image
jinge90 Jul 21, 2026
f422419
Merge branch 'main' into update_libc_container
jinge90 Jul 22, 2026
8e29764
create symlink for llvm-link instead of installing llvm-23
jinge90 Jul 23, 2026
f6980ab
revert downloading llvm-23
jinge90 Jul 23, 2026
8cbe18d
Merge branch 'main' into update_libc_container
jinge90 Jul 23, 2026
6515c28
Fold the symlink create
jinge90 Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/containers/libc/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ RUN wget https://apt.llvm.org/llvm.sh && \
RUN apt-get install -y llvm-23-tools && \
ln -s -t /usr/bin $(dpkg -L llvm-23-tools | grep '^/usr/lib/llvm-23/bin/')

# llvm-link is required to build bitcode library for GPU targets
RUN if [ ! -e /usr/bin/llvm-link ]; then \

@boomanaiden154 boomanaiden154 Jul 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop the if statement and only keep the ln -s command, and also fold this into the previous RUN line.

@jinge90 jinge90 Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @boomanaiden154
Done.
Thanks very much.

ln -s /usr/lib/llvm-23/bin/llvm-link /usr/bin/llvm-link; \
fi

# Install gmp and mpfr for cross compilation
RUN wget https://ftp.gnu.org/gnu/gmp/gmp-6.3.0.tar.xz && \
Expand Down
Loading