[Github] Install llvm-tools in libc container#210414
Merged
hulxv merged 2 commits intoJul 18, 2026
Merged
Conversation
hulxv
requested review from
bassiounix,
boomanaiden154,
lntue and
michaelrj-google
July 17, 2026 19:20
hulxv
force-pushed
the
github/workflows/containers/libc/install-llvm-tools
branch
from
July 18, 2026 19:33
f0a5703 to
8f440a7
Compare
hulxv
force-pushed
the
github/workflows/containers/libc/install-llvm-tools
branch
from
July 18, 2026 19:38
8f440a7 to
2300b53
Compare
hulxv
marked this pull request as ready for review
July 18, 2026 21:29
|
@llvm/pr-subscribers-github-workflow Author: hulxv (hulxv) ChangesCurrently, the libc container doesn't contain Full diff: https://github.com/llvm/llvm-project/pull/210414.diff 1 Files Affected:
diff --git a/.github/workflows/containers/libc/Dockerfile b/.github/workflows/containers/libc/Dockerfile
index 69f5b11cead62..063eb76326fb3 100644
--- a/.github/workflows/containers/libc/Dockerfile
+++ b/.github/workflows/containers/libc/Dockerfile
@@ -45,6 +45,8 @@ RUN wget https://apt.llvm.org/llvm.sh && \
sudo ./llvm.sh 23 && \
rm llvm.sh
+RUN apt-get install -y llvm-23-tools
+
# Install gmp and mpfr for cross compilation
RUN wget https://ftp.gnu.org/gnu/gmp/gmp-6.3.0.tar.xz && \
tar -xf gmp-6.3.0.tar.xz && \
|
boomanaiden154
approved these changes
Jul 18, 2026
| sudo ./llvm.sh 23 && \ | ||
| rm llvm.sh | ||
|
|
||
| RUN apt-get install -y llvm-23-tools |
Contributor
There was a problem hiding this comment.
Add a comment on why this is needed.
hulxv
enabled auto-merge (squash)
July 18, 2026 23:30
hulxv
added a commit
that referenced
this pull request
Jul 19, 2026
Missed thing in #210414. We need to symlink the LLVM tools that are under `/usr/lib/llvm-23/bin/` to avoid errors like this because the LLVM tools have a `-23` suffix when they're installed inside the container ``` # RUN: at line 2 /usr/bin/clang-23 -gline-tables-only -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -DCOMPILER_RT_HAS_FLOAT16 -nobuiltininc -I/__w/llvm-project/llvm-project/compiler-rt/include -idirafter /usr/lib/llvm-23/lib/clang/23/include -resource-dir=/__w/llvm-project/llvm-project/build/compiler-rt -Wl,-rpath,/__w/llvm-project/llvm-project/build/compiler-rt/lib/linux -fno-builtin -I /__w/llvm-project/llvm-project/compiler-rt/lib/builtins -nodefaultlibs /__w/llvm-project/llvm-project/compiler-rt/test/builtins/Unit/aarch64/emupac.c -lm -Wl,--start-group /__w/llvm-project/llvm-project/build/compiler-rt/lib/linux/libclang_rt.builtins-aarch64.a -lc -Wl,--end-group -o /__w/llvm-project/llvm-project/build/compiler-rt/test/builtins/Unit/AARCH64LinuxConfig/aarch64/Output/emupac.c.tmp # executed command: /usr/bin/clang-23 -gline-tables-only -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -DCOMPILER_RT_HAS_FLOAT16 -nobuiltininc -I/__w/llvm-project/llvm-project/compiler-rt/include -idirafter /usr/lib/llvm-23/lib/clang/23/include -resource-dir=/__w/llvm-project/llvm-project/build/compiler-rt -Wl,-rpath,/__w/llvm-project/llvm-project/build/compiler-rt/lib/linux -fno-builtin -I /__w/llvm-project/llvm-project/compiler-rt/lib/builtins -nodefaultlibs /__w/llvm-project/llvm-project/compiler-rt/test/builtins/Unit/aarch64/emupac.c -lm -Wl,--start-group /__w/llvm-project/llvm-project/build/compiler-rt/lib/linux/libclang_rt.builtins-aarch64.a -lc -Wl,--end-group -o /__w/llvm-project/llvm-project/build/compiler-rt/test/builtins/Unit/AARCH64LinuxConfig/aarch64/Output/emupac.c.tmp # RUN: at line 3 /__w/llvm-project/llvm-project/build/compiler-rt/test/builtins/Unit/AARCH64LinuxConfig/aarch64/Output/emupac.c.tmp 1 # executed command: /__w/llvm-project/llvm-project/build/compiler-rt/test/builtins/Unit/AARCH64LinuxConfig/aarch64/Output/emupac.c.tmp 1 # RUN: at line 4 /__w/llvm-project/llvm-project/build/compiler-rt/test/builtins/Unit/AARCH64LinuxConfig/aarch64/Output/emupac.c.tmp 2 # executed command: /__w/llvm-project/llvm-project/build/compiler-rt/test/builtins/Unit/AARCH64LinuxConfig/aarch64/Output/emupac.c.tmp 2 # RUN: at line 5 not --crash /__w/llvm-project/llvm-project/build/compiler-rt/test/builtins/Unit/AARCH64LinuxConfig/aarch64/Output/emupac.c.tmp 3 # executed command: not --crash /__w/llvm-project/llvm-project/build/compiler-rt/test/builtins/Unit/AARCH64LinuxConfig/aarch64/Output/emupac.c.tmp 3 # .---command stderr------------ # | 'not': command not found # `----------------------------- ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the libc container doesn't contain
llvm-tools. we need to use them in #200196 because we are not able to usellvm-litwithout building clang from source