Skip to content

[libc++] Implement P2442R1 std::views::chunk #171234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shyeyian wants to merge 45 commits into
base: main
Choose a base branch
from
Open

[libc++] Implement P2442R1 std::views::chunk #171234

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
f6554ea
Implement `views::chunk`.
Dec 24, 2025
af914e7
Code Review: adjust release notes
shyeyian Dec 25, 2025
dc62f79
Add Tests: test if `_LIBCPP_ASSERT_XXX` works when `views::chunk` mee…
shyeyian Dec 26, 2025
b664c0c
Fix CI: adjust `#include` path in `test/libcxx` files
shyeyian Dec 28, 2025
4dc9b06
Fix CI: add template deduction guide for `input_span<T>`
shyeyian Dec 28, 2025
1e8906a
Code Review: add `REQUIRES: std-at-least-c++23` in all the tests rela…
shyeyian Dec 28, 2025
7e21388
Fix CI: add template deduction guide for `input_span<T>` again.
shyeyian Dec 28, 2025
f1ed40a
Code review: Update libcxx/test synopsis
shyeyian Jan 15, 2026
12bec11
Code review: Fix synopsis.
shyeyian Jan 15, 2026
1e05c5a
Code review: sort and unique the tests
shyeyian Jan 15, 2026
ab00dbc
Merge remote-tracking branch 'origin/main' into ranges_chunk
ldionne Jun 19, 2026
033a1c1
Fix release notes
ldionne Jun 19, 2026
7fe126d
Resolve overload conflicts on `__div_ceil` in `ranges::chunk_view` an…
shyeyian Jun 21, 2026
d27b355
Fix test error that `constexpr` is not supported in `-std=c++03`
shyeyian Jun 21, 2026
a1a5918
Fix test error again that `constexpr` is not supported in `-std=c++11`
shyeyian Jun 21, 2026
c2e0e2e
Fix test error that `std::as_const` is included from `<utility>`.
shyeyian Jun 21, 2026
7d3cdd7
Avoid ADL in `std::__div_ceil`.
shyeyian Jun 25, 2026
116c6d8
[Important] Add missing concepts requirements.
shyeyian Jun 25, 2026
545bbdf
Cover tests on `chunk_range`. (I'll continue to cover tests on `__ite…
shyeyian Jun 26, 2026
e262f9e
Fix chunk_view ctor test for forward ranges.
shyeyian Jul 19, 2026
bf13c55
Use consistent copy_constructible spelling in chunk_view
shyeyian Jul 19, 2026
f457f26
Remove unnecessary no_unique_address from chunk_view counts
shyeyian Jul 19, 2026
39c371e
Fix chunk_view inner iter_move return type (from T into T&&)
shyeyian Jul 19, 2026
c1a0811
Add chunk_view constraint tests
shyeyian Jul 19, 2026
8085a1d
Add chunk_view iterator type tests
shyeyian Jul 19, 2026
48bf130
Add chunk_view inner iterator special member tests
shyeyian Jul 25, 2026
5d32ff5
Add chunk_view inner iterator base() test
shyeyian Jul 25, 2026
2c8a8c6
Fix input_span operator* to return a reference
shyeyian Jul 25, 2026
32f1329
Add chunk_view inner iterator iter_swap test
shyeyian Jul 25, 2026
237fa79
Add chunk_view outer iterator value_type size test
shyeyian Jul 25, 2026
b329da3
Add chunk_view outer iterator special member tests
shyeyian Jul 25, 2026
9f7ee27
Add chunk_view forward iterator base() test
shyeyian Jul 25, 2026
fb564fe
Add chunk_view forward iterator converting constructor test
shyeyian Jul 25, 2026
987eebd
Add negative comparison cases for chunk_view sentinel equality
shyeyian Jul 25, 2026
3f25401
Add chunk_view forward iterator comparison constraints and negative c…
shyeyian Jul 25, 2026
0879289
Add chunk_view iterator arithmetic test for partial final chunk
shyeyian Jul 25, 2026
7450780
Remove [[nodiscard]] from chunk_view comparison operators
shyeyian Jul 25, 2026
f3a3326
Simplify chunk_view nodiscard.verify.cpp
shyeyian Jul 25, 2026
adfc2f5
Split chunk_view compare.pass.cpp by iterator kind
shyeyian Jul 25, 2026
9384066
Split chunk_view deref.pass.cpp by iterator kind
shyeyian Jul 25, 2026
3167ebd
Split chunk_view increment.pass.cpp by iterator kind
shyeyian Jul 25, 2026
6287f7f
Split chunk_view arithmetic.pass.cpp by iterator kind
shyeyian Jul 25, 2026
5e5bd8d
Adjust test 'title' style
shyeyian Jul 25, 2026
187687d
Add [[nodiscard]] tests for full coverage
shyeyian Jul 26, 2026
eed29f4
Merge remote-tracking branch 'upstream/main' into ranges_chunk
shyeyian Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libcxx/docs/FeatureTestMacroTable.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ Status
---------------------------------------------------------- -----------------
``__cpp_lib_ranges_as_rvalue`` ``202207L``
---------------------------------------------------------- -----------------
``__cpp_lib_ranges_chunk`` *unimplemented*
``__cpp_lib_ranges_chunk`` ``202202L``
---------------------------------------------------------- -----------------
``__cpp_lib_ranges_chunk_by`` ``202202L``
---------------------------------------------------------- -----------------
Expand Down
1 change: 1 addition & 0 deletions libcxx/docs/ReleaseNotes/23.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ Implemented Papers
- P3383R3: ``mdspan.at()`` (`Github <https://llvm.org/PR175213>`__)
- P3369R0: constexpr for ``uninitialized_default_construct`` (`Github <https://llvm.org/PR118380>`__)
- P3508R0: Wording for "constexpr for specialized memory algorithms" (`Github <https://llvm.org/PR118379>`__)
- P2442R1: Windowing range adaptors: ``views::chunk`` and ``views::slide`` (`Github <https://llvm.org/PR171234>`__) (Implemented ``views::chunk`` only)

Improvements and New Features
-----------------------------
Expand Down
2 changes: 1 addition & 1 deletion libcxx/docs/Status/Cxx23Papers.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"`P2387R3 <https://wg21.link/P2387R3>`__","Pipe support for user-defined range adaptors","2022-02 (Virtual)","|Complete|","19","`#105183 <https://github.com/llvm/llvm-project/issues/105183>`__",""
"`P2440R1 <https://wg21.link/P2440R1>`__","``ranges::iota``, ``ranges::shift_left`` and ``ranges::shift_right``","2022-02 (Virtual)","|Complete|","23","`#105184 <https://github.com/llvm/llvm-project/issues/105184>`__",""
"`P2441R2 <https://wg21.link/P2441R2>`__","``views::join_with``","2022-02 (Virtual)","|Complete|","21","`#105185 <https://github.com/llvm/llvm-project/issues/105185>`__",""
"`P2442R1 <https://wg21.link/P2442R1>`__","Windowing range adaptors: ``views::chunk`` and ``views::slide``","2022-02 (Virtual)","","","`#105187 <https://github.com/llvm/llvm-project/issues/105187>`__",""
"`P2442R1 <https://wg21.link/P2442R1>`__","Windowing range adaptors: ``views::chunk`` and ``views::slide``","2022-02 (Virtual)","|Partial|","","`#105187 <https://github.com/llvm/llvm-project/issues/105187>`__","Only ``views::chunk`` is implemented."
"`P2443R1 <https://wg21.link/P2443R1>`__","``views::chunk_by``","2022-02 (Virtual)","|Complete|","18","`#105188 <https://github.com/llvm/llvm-project/issues/105188>`__",""
"","","","","","",""
"`P0009R18 <https://wg21.link/P0009R18>`__","mdspan: A Non-Owning Multidimensional Array Reference","2022-07 (Virtual)","|Complete|","18","`#105189 <https://github.com/llvm/llvm-project/issues/105189>`__",""
Expand Down
2 changes: 2 additions & 0 deletions libcxx/include/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,6 +723,7 @@ set(files
__ranges/all.h
__ranges/as_rvalue_view.h
__ranges/chunk_by_view.h
__ranges/chunk_view.h
__ranges/common_view.h
__ranges/concat_view.h
__ranges/concepts.h
Expand Down Expand Up @@ -934,6 +935,7 @@ set(files
__utility/convert_to_integral.h
__utility/declval.h
__utility/default_three_way_comparator.h
__utility/div_ceil.h
__utility/element_count.h
__utility/empty.h
__utility/exception_guard.h
Expand Down
Loading