github: fix empty continuation line; remove trailing whitespace #129535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Trailing whitespace shows up as red on my editor, so remove. - Docker on my machine warns that having lines like: ``` sudo \ foo ``` is deprecated, and will become an error, so fix that up ahead of time.
|
@llvm/pr-subscribers-github-workflow Author: George Burgess IV (gburgessiv) Changes
is deprecated, and will become an error, so fix that up ahead of time. Full diff: https://github.com/llvm/llvm-project/pull/129535.diff 1 Files Affected:
diff --git a/.github/workflows/containers/github-action-ci/Dockerfile b/.github/workflows/containers/github-action-ci/Dockerfile
index 377b8f14402ee..bd3720017b7f7 100644
--- a/.github/workflows/containers/github-action-ci/Dockerfile
+++ b/.github/workflows/containers/github-action-ci/Dockerfile
@@ -40,7 +40,7 @@ RUN cmake -B ./build -G Ninja ./llvm \
RUN ninja -C ./build stage2-clang-bolt stage2-install-distribution && ninja -C ./build install-distribution
FROM base as ci-container
-
+
COPY --from=stage1-toolchain $LLVM_SYSROOT $LLVM_SYSROOT
# Need to install curl for hendrikmuhs/ccache-action
@@ -49,7 +49,7 @@ COPY --from=stage1-toolchain $LLVM_SYSROOT $LLVM_SYSROOT
# Need git for SPIRV-Tools tests.
RUN apt-get update && \
DEBIAN_FRONTEND=noninteractive apt-get install -y \
- binutils \
+ binutils \
cmake \
curl \
git \
@@ -59,7 +59,6 @@ RUN apt-get update && \
perl-modules \
python3-psutil \
sudo \
-
# These are needed by the premerge pipeline. Pip is used to install
# dependent python packages and ccache is used for build caching. File and
# tzdata are used for tests.
|
tstellar
approved these changes
Mar 3, 2025
boomanaiden154
approved these changes
Mar 3, 2025
|
Thank you both! |
gburgessiv
deleted the
github-fix-empty-continuation-line-remove-trailing-whitespace
branch
jph-13
pushed a commit
to jph-13/llvm-project
that referenced
this pull request
Mar 21, 2025
…#129535) - Trailing whitespace shows up as red on my editor, so remove. - Docker on my machine warns that having line continuations like: ``` sudo \ foo ``` is deprecated, and will become an error, so fix that up ahead of time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is deprecated, and will become an error, so fix that up ahead of time.