chore: enhance logging and error handling in file manager components #2917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improved logging statements across various file manager modules, including DragMonitor, Workspace, and menu handling, to provide clearer insights during operations. - Added checks and warnings for null pointers and invalid states, enhancing error handling in file operations and user interactions. - Streamlined logging practices to ensure consistency and better maintainability throughout the file manager codebase. Log: This commit enhances the logging and error handling mechanisms in the file manager, improving overall visibility and robustness during operations.
Reviewer's GuideThis PR introduces comprehensive logging across the file manager codebase—with fmDebug/fmInfo/fmWarning statements inserted in constructors, key methods, callbacks, and error paths—while adding guard checks for null or invalid inputs and standardizing log level usage. It also enriches file traversal and data-fetching modules with detailed operational tracing and context. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Kakueeen - I've reviewed your changes - here's some feedback:
- The sheer volume of debug/info logs—especially inside hot loops like file iteration and UI paint routines—could introduce performance overhead and clutter; consider auditing log levels and trimming verbosity in performance-critical paths.
- You’ve added many null-pointer and invalid-state checks with warnings; consolidating these guards into shared helper functions or macros would reduce boilerplate and ensure consistent error handling.
- To make post-mortem debugging easier, include consistent context (such as window IDs, URLs, or traversal tokens) in each log message and adhere strictly to structured log levels (debug/info/warning).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The sheer volume of debug/info logs—especially inside hot loops like file iteration and UI paint routines—could introduce performance overhead and clutter; consider auditing log levels and trimming verbosity in performance-critical paths.
- You’ve added many null-pointer and invalid-state checks with warnings; consolidating these guards into shared helper functions or macros would reduce boilerplate and ensure consistent error handling.
- To make post-mortem debugging easier, include consistent context (such as window IDs, URLs, or traversal tokens) in each log message and adhere strictly to structured log levels (debug/info/warning).
## Individual Comments
### Comment 1
<location> `src/plugins/filemanager/dfmplugin-workspace/utils/filedatamanager.cpp:33` </location>
<code_context>
return rootInfoMap.value(url);
+ }
+ fmInfo() << "Creating new RootInfo for URL:" << url.toString();
return createRoot(url);
}
</code_context>
<issue_to_address>
Filter root creation logs or guard by level
Consider filtering these logs or using `fmDebug` to prevent excessive info-level log output during frequent navigation.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
fmInfo() << "Creating new RootInfo for URL:" << url.toString();
=======
fmDebug() << "Creating new RootInfo for URL:" << url.toString();
>>>>>>> REPLACE
</suggested_fix>
### Comment 2
<location> `src/plugins/filemanager/dfmplugin-workspace/views/iconitemdelegate.cpp:58` </location>
<code_context>
{
Q_D(IconItemDelegate);
+ fmInfo() << "Creating IconItemDelegate";
+
d->expandedItem = new ExpandedItem(this, parent->parent()->viewport());
</code_context>
<issue_to_address>
Info-level log in constructor may be too coarse
Frequent delegate construction may clutter info logs; consider using `fmDebug()` for less verbosity.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| fmInfo() << "Creating new RootInfo for URL:" << url.toString(); |
There was a problem hiding this comment.
suggestion: Filter root creation logs or guard by level
Consider filtering these logs or using fmDebug to prevent excessive info-level log output during frequent navigation.
Suggested change
| fmInfo() << "Creating new RootInfo for URL:" << url.toString(); | |
| fmDebug() << "Creating new RootInfo for URL:" << url.toString(); |
| @@ -55,12 +55,17 @@ IconItemDelegate::IconItemDelegate(FileViewHelper *parent) | |||
| { | |||
| Q_D(IconItemDelegate); | |||
|
|
|||
| fmInfo() << "Creating IconItemDelegate"; | |||
There was a problem hiding this comment.
nitpick: Info-level log in constructor may be too coarse
Frequent delegate construction may clutter info logs; consider using fmDebug() for less verbosity.
Johnson-zs
approved these changes
Jun 17, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Johnson-zs, Kakueeen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: behind) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log: This commit enhances the logging and error handling mechanisms in the file manager, improving overall visibility and robustness during operations.
Summary by Sourcery
Enhance visibility and robustness of the file manager plugin by adding comprehensive logging and error checks across core components.
Bug Fixes:
Enhancements:
Chores: