Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdate tox-lsr from v3.12.0 to v3.13.0 in all CI workflows to incorporate the missing extra_images file fix for QEMU integration tests. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider extracting the tox-lsr version into a workflow variable or reusable workflow to avoid duplication and simplify future version bumps.
- If tox-lsr is available on PyPI, switching from the git+ URL to pip install tox-lsr==3.13.0 could improve install speed and caching.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider extracting the tox-lsr version into a workflow variable or reusable workflow to avoid duplication and simplify future version bumps.
- If tox-lsr is available on PyPI, switching from the git+ URL to pip install tox-lsr==3.13.0 could improve install speed and caching.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
fixes ci failure in qemu test related to missing extra_images file https://github.com/linux-system-roles/tox-lsr/releases/tag/3.13.0 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes ci failure in qemu test related to missing extra_images file
https://github.com/linux-system-roles/tox-lsr/releases/tag/3.13.0