Skip to content

feat: add aud claim for oauth2proxy #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025
Merged

feat: add aud claim for oauth2proxy #253

merged 2 commits into from
Jul 2, 2025

Conversation

ElderMatt
Copy link
Collaborator

@ElderMatt ElderMatt commented Jun 26, 2025

This PR adds the aud claim to Otomi-dedicated for oauth2-proxy oidc configuration.

Combined with apl-core PR

@ElderMatt ElderMatt requested a review from CasLubbers as a code owner June 26, 2025 12:10
Copy link

github-actions bot commented Jun 26, 2025

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
33.91% (+0.05% 🔼)
393/1159
🔴 Branches
15.27% (-0.06% 🔻)
42/275
🔴 Functions
19.05% (-0.28% 🔻)
40/210
🔴 Lines
34.38% (+0.05% 🔼)
360/1047
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / keycloak.ts
11.8% (-0.16% 🔻)
6.86% (-0.07% 🔻)
6.78% (-0.12% 🔻)
12.68% (-0.15% 🔻)

Test suite run success

25 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from c2a1ece

@ferruhcihan ferruhcihan self-assigned this Jun 30, 2025
Copy link
Collaborator

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM 👍🏻

@j-zimnowoda j-zimnowoda merged commit f74e44f into main Jul 2, 2025
7 checks passed
@j-zimnowoda j-zimnowoda deleted the APL-894 branch July 2, 2025 15:00
ferruhcihan pushed a commit that referenced this pull request Jul 3, 2025
* feat: add aud claim for oauth2proxy

* fix: use keycloak client id instead of hardcoded

(cherry picked from commit f74e44f)
ferruhcihan added a commit that referenced this pull request Jul 3, 2025
* chore: release branch [ci skip]

* feat: add the aud claim for oauth2proxy (#253)

* feat: add aud claim for oauth2proxy

* fix: use keycloak client id instead of hardcoded

(cherry picked from commit f74e44f)

* chore(release): 3.13.1

* chore(release): 3.13.1

---------

Co-authored-by: ElderMatt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants