-
Notifications
You must be signed in to change notification settings - Fork 170
feat: set custom repository and use selectors on argocd applications #2286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment. Code looks good to me
I realized that using the selectors on |
It's not exactly the same right? In the apply we also update the deployment state in the configmap and make sure that some k8s resources are there. |
📌 Summary
This PR adds two features to the
otomi apply
command:APPS_REPO_URL
andAPPS_REVISION
, which allow configuring therepoURL
andtargetRevision
of ArgoCD application manifests when usingotomi apply-as-apps
orotomi apply --tekton
. This way, feature branches can be pushed to other locations than the public GitHub repo for experimental purposes.otomi apply --tekton
supports selectors, e.g. by file or name, for selectively configuring the ArgoCD applications.These two come in useful when testing a new version of an app, without pushing all incremental changes to GitHub. Also, using the selectors, it does not keep re-enabling
apl-operator
, reverting any potential changes sent from a local Otomi CLI. Application upgrades can be tested on top of different releases, e.g.main
and the previous release, without creating a separate feature branch for each combination.Example, which only updates a single app with a new chart (provided that the Core repo was mirrored to the cluster):
🔍 Reviewer Notes
These changes are for development use. Without setting any environment variables or selectors, they should not affect the behavior of the apl-operator.
🧹 Checklist