feat: adding KnativeServing CR ORCS support #2260
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-zimnowoda
reviewed
Jun 20, 2025
| default: "{{ $v.otomi.linodeLkeImageRepository }}/gcr/knative-releases/knative.dev/serving/cmd/${NAME}" | ||
| override: | ||
| migrate: "{{ $v.otomi.linodeLkeImageRepository }}/gcr/knative-releases/knative.dev/pkg/apiextensions/storageversion/cmd/migrate" | ||
| cleantup: "{{ $v.otomi.linodeLkeImageRepository }}/gcr/knative-releases/knative.dev/serving/pkg/cleanup/cmd/cleanup" |
There was a problem hiding this comment.
It looks like typo cleantup => cleanup?
j-zimnowoda
reviewed
Jun 20, 2025
| @@ -6,6 +6,13 @@ metadata: | |||
| name: knative-serving | |||
| namespace: knative-serving | |||
| spec: | |||
| {{- if $v.otomi.linodeLkeImageRepository }} | |||
| registry: | |||
| default: "{{ $v.otomi.linodeLkeImageRepository }}/gcr/knative-releases/knative.dev/serving/cmd/${NAME}" | |||
There was a problem hiding this comment.
This is a bit confusing because you define images through both a pattern (implicitly) and through override (explicitly). I would rather use override only,
There was a problem hiding this comment.
It seems the operator itself is using sha's to pull the images created for this CR. Overriding seems to use the latest tag if no specific version is configured.
#kubectl get pods --all-namespaces -o jsonpath="{.items[*].spec['initContainers', 'containers'][*].image}" |tr -s '[[:space:]]' '\n' |sort |uniq -c | awk '{print $2}' | sort -u | grep "knative"
gcr.io/knative-releases/knative.dev/net-istio/cmd/controller@sha256:18376be76f77cd195e2bb4993eebf86c6b8c34222247f2f8e4a265c5c4e9b9a8
gcr.io/knative-releases/knative.dev/net-istio/cmd/webhook@sha256:dcc32d23e1565c26620c3735c28ea294215e8b01dd9a30b58e19152879b89422
gcr.io/knative-releases/knative.dev/operator/cmd/operator:v1.18.1
gcr.io/knative-releases/knative.dev/operator/cmd/webhook:v1.18.1
gcr.io/knative-releases/knative.dev/serving/cmd/activator@sha256:80b2e4bf6df496c692f8e148b3a72afcb88165cb7428e52b788fa53075989655
gcr.io/knative-releases/knative.dev/serving/cmd/autoscaler-hpa@sha256:b954b12cf7575d1d505a243f71aa252922f973a614d878549a4758ed92fd7f77
gcr.io/knative-releases/knative.dev/serving/cmd/autoscaler@sha256:6ff1f7816c67954f4533edd7a7e35882e2d52613cc3343594ff3eddfd0c1fca2
gcr.io/knative-releases/knative.dev/serving/cmd/controller@sha256:d4c6a0f926509e8d34795003635fdb8625dd3d4648ec55fe2ce781e0b8750e04
gcr.io/knative-releases/knative.dev/serving/cmd/webhook@sha256:6fb473eb7641c3f7174ed4064e6c3f5eeeb05e1420f5af425bbec33af53f4f92
After this change is applied:
#kubectl get pods --all-namespaces -o jsonpath="{.items[*].spec['initContainers', 'containers'][*].image}" |tr -s '[[:space:]]' '\n' |sort |uniq -c | awk '{print $2}' | sort -u | grep "knative"
mirror.registry.linodelke.net/gcr/knative-releases/knative.dev/operator/cmd/operator:v1.18.1
mirror.registry.linodelke.net/gcr/knative-releases/knative.dev/operator/cmd/webhook:v1.18.1
mirror.registry.linodelke.net/gcr/knative-releases/knative.dev/serving/cmd/activator
mirror.registry.linodelke.net/gcr/knative-releases/knative.dev/serving/cmd/autoscaler
mirror.registry.linodelke.net/gcr/knative-releases/knative.dev/serving/cmd/autoscaler-hpa
mirror.registry.linodelke.net/gcr/knative-releases/knative.dev/serving/cmd/controller
mirror.registry.linodelke.net/gcr/knative-releases/knative.dev/serving/cmd/webhook
mirror.registry.linodelke.net/gcr/knative-releases/knative.dev/serving/pkg/cleanup/cmd/cleanup
There was a problem hiding this comment.
I see it is a bit problematic because it seems that we can't lock the version tag.
j-zimnowoda
requested changes
Jun 20, 2025
|
Hardcoded the version in the gotmpl. Also there is already a version in there which needs to be updated. So I think its fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
APL-887
This PR configures the KnativeServing CR to use images from ORCS when useORCS is set to true.
Knative documentation
🔍 Reviewer Notes
🧹 Checklist