Skip to content

Conversation

@matentzn
Copy link

No description provided.

class_named:
description: local alias for the class

ObjectDerivation:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change - in discussion with @amc-corey-cox this was missing from the metamodel.

}
},
)
value: Optional[Any] = Field(
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was in pydantic, but I cant see how this could have come from the linkml model. Ideas @amc-corey-cox?

Deleted the ObjectDerivation class and its attributes from transformer_model.yaml, likely as part of a model simplification or refactor.
@amc-corey-cox
Copy link
Contributor

The description field you added to TransformationSpecification is actually already inherited from SpecificationComponent (the parent class), so that addition can be removed. The other new fields (publication_date, license, version, creator_id, author_id, mapping_method) are the actual new additions.

I'll fix up the conflicts with main and update the tests so this is ready to go.

@amc-corey-cox
Copy link
Contributor

@matentzn I fixed the conflicts you were running into and I think this could be ready to merge in. If you're happy with what we have here just click the "Ready for review" button to take this off of draft mode. I'll review it and merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants