-
Notifications
You must be signed in to change notification settings - Fork 3
Add first version of enhanced mapping metadata #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Without this the pydantic generation is failing
| class_named: | ||
| description: local alias for the class | ||
|
|
||
| ObjectDerivation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated change - in discussion with @amc-corey-cox this was missing from the metamodel.
| } | ||
| }, | ||
| ) | ||
| value: Optional[Any] = Field( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was in pydantic, but I cant see how this could have come from the linkml model. Ideas @amc-corey-cox?
Deleted the ObjectDerivation class and its attributes from transformer_model.yaml, likely as part of a model simplification or refactor.
|
The description field you added to TransformationSpecification is actually already inherited from SpecificationComponent (the parent class), so that addition can be removed. The other new fields (publication_date, license, version, creator_id, author_id, mapping_method) are the actual new additions. I'll fix up the conflicts with main and update the tests so this is ready to go. |
|
@matentzn I fixed the conflicts you were running into and I think this could be ready to merge in. If you're happy with what we have here just click the "Ready for review" button to take this off of draft mode. I'll review it and merge it in. |
…l-map into linkml-map-metadata
it already has subject_schema, object_schema; I will add the other details later.
No description provided.