Skip to content

Replace PPC_FUNC_NAME with ppc::util::FuncName() implementation #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 23, 2025

Conversation

allnes
Copy link
Member

@allnes allnes commented Jun 22, 2025

No description provided.

@github-actions github-actions bot added the core label Jun 22, 2025
allnes added 2 commits June 22, 2025 12:48
…me()`
…cOS workflow with Xcode setup
@github-actions github-actions bot added the ci label Jun 22, 2025
@allnes allnes requested a review from aobolensk June 22, 2025 11:16
Copy link

codecov bot commented Jun 22, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.73%. Comparing base (579cc16) to head (462acd5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
modules/core/util/include/util.hpp 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
- Coverage   92.15%   91.73%   -0.43%     
==========================================
  Files          11       11              
  Lines         357      363       +6     
  Branches      127      131       +4     
==========================================
+ Hits          329      333       +4     
  Misses         10       10              
- Partials       18       20       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@allnes allnes requested a review from aobolensk June 22, 2025 11:59
* @details
* - On GCC/Clang, function_name() returns a pretty signature
* including namespaces, templates, and parameters.
* - On MSVC, it also includes return type and calling convention.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should that be included?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aobolensk corrected

- name: Install Xcode
uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: 'latest'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, move to the separate PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aobolensk done

- name: Install Xcode
uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: 'latest'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using latest-stable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aobolensk done

allnes added 2 commits June 23, 2025 23:10
…_programming_course into an/change-define

# Conflicts:
#	.github/workflows/mac.yml
@allnes allnes requested a review from aobolensk June 23, 2025 21:13
@github-actions github-actions bot removed the ci label Jun 23, 2025
@aobolensk aobolensk enabled auto-merge June 23, 2025 21:23
@aobolensk aobolensk added this pull request to the merge queue Jun 23, 2025
Merged via the queue into learning-process:master with commit 59ae80a Jun 23, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants