-
Notifications
You must be signed in to change notification settings - Fork 73
Replace PPC_FUNC_NAME with ppc::util::FuncName()
implementation
#460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…me()`
…cOS workflow with Xcode setup
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #460 +/- ##
==========================================
- Coverage 92.15% 91.73% -0.43%
==========================================
Files 11 11
Lines 357 363 +6
Branches 127 131 +4
==========================================
+ Hits 329 333 +4
Misses 10 10
- Partials 18 20 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
modules/core/util/include/util.hpp
Outdated
* @details | ||
* - On GCC/Clang, function_name() returns a pretty signature | ||
* including namespaces, templates, and parameters. | ||
* - On MSVC, it also includes return type and calling convention. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should that be included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aobolensk corrected
.github/workflows/mac.yml
Outdated
- name: Install Xcode | ||
uses: maxim-lobanov/setup-xcode@v1 | ||
with: | ||
xcode-version: 'latest' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, move to the separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aobolensk done
.github/workflows/mac.yml
Outdated
- name: Install Xcode | ||
uses: maxim-lobanov/setup-xcode@v1 | ||
with: | ||
xcode-version: 'latest' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using latest-stable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aobolensk done
…_programming_course into an/change-define # Conflicts: # .github/workflows/mac.yml
No description provided.