Skip to content

Fix pipeline stage check and add tests #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aobolensk
Copy link
Member

@aobolensk aobolensk commented Jun 20, 2025

  • Avoid invalid iterators in IsFullPipelineStage
  • Test premature PostProcessing calls

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.15%. Comparing base (0cdc845) to head (d808d62).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
modules/core/task/include/task.hpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
- Coverage   92.41%   92.15%   -0.26%     
==========================================
  Files          11       11              
  Lines         356      357       +1     
  Branches      125      127       +2     
==========================================
  Hits          329      329              
  Misses         10       10              
- Partials       17       18       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aobolensk aobolensk force-pushed the codex/modify-isfullpipelinestage-logic-and-add-tests branch from 1bf2786 to e1ead00 Compare June 22, 2025 15:41
100

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@aobolensk aobolensk added this pull request to the merge queue Jun 22, 2025
@aobolensk aobolensk removed this pull request from the merge queue due to a manual request Jun 22, 2025
@aobolensk aobolensk merged commit e8c853a into master Jun 22, 2025
75 of 76 checks passed
@aobolensk aobolensk deleted the codex/modify-isfullpipelinestage-logic-and-add-tests branch June 24, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant