Skip to content

add testmath as amsmath test file #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mbertucci47
Copy link
Collaborator

Uses the file testmath.tex as a test file for amsmath. So it didn't error, I made the adjustments

  • convert all P_\X to P_{\X} (for unicode-math)
  • comment out redefinition of \@makecol
  • until new luamml is released, comment out smallmatrix envs (smallmatrix luamml issue #875)

I tried running it with tagging-setup={math/setup=mathml-SE} as well but this results in a lot of warnings. When I tried to isolate the warnings in a MWE, they went away so I gave up. It is also somewhat difficult to debug because either the line numbers in the warning seem wrong or there are no line numbers in the warning.

Copy link
Member

@FrankMittelbach FrankMittelbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are in the process of setting up auto testing of all test files you might consider keeping failures as part of the test. Then corrections like a new luamml will generate a diff when an issue is resolved (but I don't know how long it will take to see this being activated).

@u-fischer
Copy link
Member

u-fischer commented Jun 20, 2025

With the development version of tagpdf and luamml tagging-setup={math/setup=mathml-SE} there aren't so many parent-child warnings anymore (but the first one looks like a real problem, see also #919), but compilation fails with warning (nodes): node 28050 has an attribute list that is free already, case 1. So something is really amiss here.

I opened an issue about the crash #921

@mbertucci47
Copy link
Collaborator Author

Okay I added back the smallmatrix envs

@zauguin
Copy link
Member

zauguin commented Jun 21, 2025

We just merged the change to do automated testing, so it would be awesome if this MR could be rebased and adjusted:

  • The testfile should be moved from tagging-status/testfiles to tagging-status/testfiles-broken to indicate that the result has known issues.
  • A corresponding reference file should be created with l3build -c config-broken save testmath-tagged

@mbertucci47
Copy link
Collaborator Author

@zauguin Which directory do I run the l3build command in? Also, is that the right syntax? When I do that it says the usage is wrong

@FrankMittelbach
Copy link
Member

@zauguin Which directory do I run the l3build command in? Also, is that the right syntax? When I do that it says the usage is wrong

l3build save -c ... I guess. And in the dir where the config file is.

@mbertucci47
Copy link
Collaborator Author

Okay should be good now

@zauguin
Copy link
Member

zauguin commented Jun 22, 2025

@mbertucci47 Thanks. Could you also move the .struct.xml files into the amsmath directory with the test?

@mbertucci47
Copy link
Collaborator Author

@zauguin I moved the xml files. Is there any way to make that automatic when l3build is run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants