fix: v2.2.1 — bundle slf4j-nop for standalone agent mode#30
Merged
Conversation
…Easy, auto log correlation
- DB span names follow OTel convention: {OPERATION} {db.name}.{table}
- Reactive SQL db.name, net.peer.name, net.peer.port from connection options
- RESTEasy (JAX-RS) http.route from @path annotations
- Core Router auto-instrumentation (non-RxJava) with dedup
- HTTP client traceparent injection and response status code
- Aerospike batch operation coverage
- Jedis Redis instrumentation (Connection.sendCommand)
- Lettuce Redis instrumentation (AbstractRedisAsyncCommands.dispatch)
- Raw JDBC Statement instrumentation (execute* methods)
- Auto log-trace correlation (MdcTraceTurboFilter + OpenTelemetryAppender)
- EC2 deployment options in README
- Docker ARG VERSION in agent Dockerfiles
- Bump central-publishing-maven-plugin to 0.7.0
- README redesigned with complete feature coverage
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
prathamesh-sonpatki
force-pushed
the
feat/core-router-and-sql-span-naming
branch
from
63d51a5 to
ce0aaca
Compare
AgentBootstrap.premain() initialized OTel SDK before installing ByteBuddy transformers, causing CLIENT spans (Aerospike, Kafka, HTTP, JDBC) to be silently lost when SDK init triggered class loading of application clients. Changes: - AgentBootstrap: swap steps 3/4 — install transformers FIRST, then SDK init - Vertx3Instrumenter: upgrade instrumentation skip logs from debug to warn, add loaded flag to onTransformation log for diagnosing retransform issues - ResteasyDispatchHelper: fix route template extraction to scan all methods instead of short-circuiting on first no-@path match; match by segment count Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Resolve conflicts from release/2.1.0 merge (PR #29) — keep 2.2.0 version and our branch's superset of changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The standalone agent (vertx3-otel-agent) crashed with NoClassDefFoundError: org/slf4j/LoggerFactory when loaded as -javaagent because the shade plugin excluded slf4j-api from agent-impl.jar. In agent mode, the app classpath isn't available when premain runs, so classes with static SLF4J loggers (OtelAgent, Vertx3Instrumenter) failed during <clinit>. - Bundle slf4j-nop in the shaded JAR as a fallback SLF4J binding. The app's real binding (logback) takes precedence since appendToSystemClassLoaderSearch appends after the app classpath. - Remove SLF4J from OtelAgent.java, use System.err instead (consistent with AgentBootstrap, avoids early classloading). - Bump version to 2.2.1. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
prathamesh-sonpatki
changed the title
muktaa
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vertx3-otel-agentJAR crashed withNoClassDefFoundError: org/slf4j/LoggerFactorywhen used as-javaagentbecause the shade plugin excluded SLF4J fromagent-impl.jar. In agent mode, the app classpath isn't available atpremaintime.slf4j-nopin the shaded JAR as a fallback binding. The app's real binding (logback) takes precedence sinceappendToSystemClassLoaderSearchappends after the app classpath.OtelAgent.java, useSystem.errinstead (consistent withAgentBootstrap).Test plan
NoClassDefFoundError: org/slf4j/LoggerFactory🤖 Generated with Claude Code