Open
Conversation
Adds support for the Trilogy MySQL client (used by GitHub, built into Rails 7.1+). Follows the same pattern as the existing Mysql2 adapter. New files: - lib/rails_otel_context/adapters/trilogy.rb - test/trilogy_adapter_test.rb (8 tests) Modified files: - lib/rails_otel_context/adapters.rb - register Trilogy adapter - lib/rails_otel_context/configuration.rb - add trilogy config options - lib/rails_otel_context.rb - add env var support - test/configuration_test.rb - add Trilogy env var assertions Configuration: trilogy_slow_query_enabled (default: true) trilogy_slow_query_threshold_ms (default: 200.0) Environment variables: RAILS_OTEL_CONTEXT_TRILOGY_SLOW_QUERY_ENABLED RAILS_OTEL_CONTEXT_TRILOGY_SLOW_QUERY_MS
Member
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. The Trilogy adapter correctly follows the established MySQL2 adapter pattern with appropriate differences:
🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
::Trilogy#queryto add source location, ActiveRecord context, and slow query duration attributes to OTel spanstrilogy_slow_query_enabled,trilogy_slow_query_threshold_ms) with env var supportTest plan
🤖 Generated with Claude Code