Conversation
Cover span creation, naming, HTTP attributes, status code recording, 5xx/4xx error status, W3C trace context propagation, and span context injection into the downstream request context. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Hoist trace.WithSpanKind(Server) to construction time (removes per-request closure alloc) - Inline opts slice directly into tracer.Start - Replace fmt.Sprintf span name with string concat - Remove what-comments in hot path (kept route-pattern limitation comment) - Collapse 4 status-code tests into one table-driven test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
muktaa
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainMiddleware()functionTests cover
METHOD /pathhttp.request.method,url.path,server.addresshttp.response.status_code)Error; 4xx and 2xx do notSpanKindisServertraceparentheader creates a child span with matching trace IDTest plan
go test ./instrumentation/beego/...— all 13 tests passgolangci-lint run ./instrumentation/beego/...— clean🤖 Generated with Claude Code