FDE-57: feat(database): expose ParseDSNAttributes as public API#18
Merged
karthikeyangs9 merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
Renames unexported extractDSNAttributes to ParseDSNAttributes so callers can stamp server.address, server.port, db.user, and db.name onto manually created wrapper spans — not just on spans auto-generated by otelsql. span.SetAttributes(database.ParseDSNAttributes(dsn, "mysql")...) Adds unit tests covering Postgres, MySQL (with/without port, with query params), SQLite (no network attrs), and empty DSN edge cases. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
karthikeyangs9
approved these changes
Feb 27, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extractDSNAttributes→ParseDSNAttributesto expose it as a public APIProblem
Users creating manual wrapper spans for DB operations (e.g.
FindTopicByID) were missingserver.address,server.port,db.userattributes. These were only being added to spans auto-generated by otelsql, not to hand-rolled spans using a custom tracer scope.Usage
Linear
https://linear.app/last9/issue/FDE-57
Test plan
go test ./integrations/database/... -run TestParseDSN(8 cases, all passing)golangci-lint run ./integrations/database/...— clean🤖 Generated with Claude Code