[12.x] Allow passing an enum to Builder::orderBy()
#56250
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At work, we have three or four separate projects, each which has a SortDirection enum. We use the enum to validate against in HTTP requests, but always have to remember to add
->value
when sorting, eg)Athlete::query()->orderBy('last_name', $request->sort->direction->value)
.I believe it is a mathematical impossibility that we are the only folks who have this issue. This is certainly not broken as-is, just adding a small quality of life improvement for improved DX.