- 
                Notifications
    You must be signed in to change notification settings 
- Fork 249
feat: support passthrough propagation to plugins #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| Summary of ChangesHello @ywqwancbx, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a flexible  Highlights
 Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either  
 Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a  Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for passthrough propagation to plugins by adding a passthrough field to InvokePluginRequest and Session structs. The changes are logical and correctly implemented to pass this new field through the system. My review found one minor formatting issue that should be addressed for code consistency.
| AppID *string `json:"app_id"` | ||
| EndpointID *string `json:"endpoint_id"` | ||
| Context map[string]any `json:"context"` | ||
| Passthrough *string `json:"passthrough"` | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation for the new Passthrough field is using spaces instead of a tab. Standard Go formatting, enforced by tools like gofmt, uses tabs for indentation. Please correct the indentation to maintain code style consistency.
| Passthrough *string `json:"passthrough"` | |
| Passthrough *string `json:"passthrough"` | 
Passthrough Propagation to Plugins
passthroughtoInvokePluginRequestandSession, and include it inSession.Message()so it reaches the Python SDK as a first-class field (similar toconversation_id).InvokeTooldata payload strictly for business parameters; carrypassthroughvia session to avoid schema drift.