feat: add apache gravitino lance namespace implementations#9
feat: add apache gravitino lance namespace implementations#9shaofengshi wants to merge 3 commits intolance-format:mainfrom
Conversation
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
|
Can somebody review my PR? Thanks! |
|
I am a bit confused, I thought it could directly work with the RestNamespace which is in core lance repo? Why do we need this implementation? |
Good quesiton! Although Gravitino implements the Lance REST API spec, its specific conventions, URL structure, hierarchy rules, and ecosystem integration requirements make a dedicated implementation more maintainable, user-friendly, and robust than trying to use a generic REST client. For example: Gravitino enforces a strict three-level hierarchy (catalog → schema → table) that requires validation:
This is why we add this: make user easier to get started with it. Hope this helps. |
|
Sorry for the late reply, was a bit sick past few days. I checked in details about this implementation compared to the one in lance main repo. Looks like there are 2 key differences:
I think we probably want to handle them differently. For 1, there has been multiple discussions about this in other contexts, which all point to the same solution: what we should do is a For 2, I think that is totally reasonable feature to add directly in What do you think? |
|
Hi Jack, I agree with you; If Lance namespace implementation can support above features natively, that would be great for other implementations! Then what's your suggestion for this PR? Could we merge it first and update later when Lance namespace implementation get updated? Thanks! |
|
Looks like for 2, it is already supported today: For 1, would you be interested in the implementation? But overall I think we should not merge this, since the goal of doing a REST namespace server is that it uses the Rest namespace that is maintained in the core lance repo that gets all the first-class integration and testing. Doing this defeats that purpose. |
|
I understand. Sure, for issue 1, I can work on it; But I'm not sure which repo should it be contribute to, the lance-format/lance-namespace one or this one; if you already have some decisions, please share to me, thank you! @jackye1995 |
|
Jack, for the issue 1, new PR is created, please take a look: #31 @jackye1995 |

Apache Gravitino v1.1.0 has released its implementation for Lance Rest service, see https://gravitino.apache.org/docs/1.1.0/lance-rest-service
Now I add the implementation for user to easily adopt that. This pr includes:
The gravitino_example.py can be directly run after start a Gravitino docker container in local.