-
Notifications
You must be signed in to change notification settings - Fork 78
feat(FR-1885): Replace hardcoded e2e test credentials with environment variables #4987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+60
−15
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,27 @@ | ||
| SCREENSHOT_PATH=./screenshots | ||
| SCREENSHOT_PATH=./screenshots | ||
|
|
||
| # E2E Test Configuration | ||
| # Endpoints | ||
| E2E_WEBUI_ENDPOINT=http://127.0.0.1:9081 | ||
| E2E_WEBSERVER_ENDPOINT=http://127.0.0.1:8090 | ||
|
|
||
| # User Credentials | ||
| # Admin user | ||
| [email protected] | ||
| E2E_ADMIN_PASSWORD=wJalrXUt | ||
|
|
||
| # Regular user | ||
| [email protected] | ||
| E2E_USER_PASSWORD=C8qnIo29 | ||
|
|
||
| # Second regular user | ||
| [email protected] | ||
| E2E_USER2_PASSWORD=P7oxTDdz | ||
|
|
||
| # Monitor user | ||
| [email protected] | ||
| E2E_MONITOR_PASSWORD=7tuEwF1J | ||
|
|
||
| # Domain admin user | ||
| [email protected] | ||
| E2E_DOMAIN_ADMIN_PASSWORD=cWbsM_vB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,8 +2,8 @@ import { FolderCreationModal } from './classes/FolderCreationModal'; | |
| import TOML from '@iarna/toml'; | ||
| import { APIRequestContext, Locator, Page, expect } from '@playwright/test'; | ||
|
|
||
| export const webuiEndpoint = 'http://127.0.0.1:9081'; | ||
| export const webServerEndpoint = 'http://127.0.0.1:8090'; | ||
| export const webuiEndpoint = process.env.E2E_WEBUI_ENDPOINT || 'http://127.0.0.1:9081'; | ||
| export const webServerEndpoint = process.env.E2E_WEBSERVER_ENDPOINT || 'http://127.0.0.1:8090'; | ||
| export const visualRegressionWebserverEndpoint = 'http://10.122.10.216:8090'; | ||
|
|
||
| export async function login( | ||
|
|
@@ -22,24 +22,24 @@ export async function login( | |
|
|
||
| export const userInfo = { | ||
| admin: { | ||
| email: '[email protected]', | ||
| password: 'wJalrXUt', | ||
| email: process.env.E2E_ADMIN_EMAIL || '[email protected]', | ||
| password: process.env.E2E_ADMIN_PASSWORD || 'wJalrXUt', | ||
| }, | ||
| user: { | ||
| email: '[email protected]', | ||
| password: 'C8qnIo29', | ||
| email: process.env.E2E_USER_EMAIL || '[email protected]', | ||
| password: process.env.E2E_USER_PASSWORD || 'C8qnIo29', | ||
| }, | ||
| user2: { | ||
| email: '[email protected]', | ||
| password: 'P7oxTDdz', | ||
| email: process.env.E2E_USER2_EMAIL || '[email protected]', | ||
| password: process.env.E2E_USER2_PASSWORD || 'P7oxTDdz', | ||
| }, | ||
| monitor: { | ||
| email: '[email protected]', | ||
| password: '7tuEwF1J', | ||
| email: process.env.E2E_MONITOR_EMAIL || '[email protected]', | ||
| password: process.env.E2E_MONITOR_PASSWORD || '7tuEwF1J', | ||
| }, | ||
| domainAdmin: { | ||
| email: '[email protected]', | ||
| password: 'cWbsM_vB', | ||
| email: process.env.E2E_DOMAIN_ADMIN_EMAIL || '[email protected]', | ||
| password: process.env.E2E_DOMAIN_ADMIN_PASSWORD || 'cWbsM_vB', | ||
| }, | ||
| }; | ||
|
|
||
|
|
@@ -56,7 +56,7 @@ export async function loginAsDomainAdmin(page: Page) { | |
| page, | ||
| userInfo.domainAdmin.email, | ||
| userInfo.domainAdmin.password, | ||
| 'http://127.0.0.1:8090', | ||
| webServerEndpoint, | ||
| ); | ||
| } | ||
| export async function loginAsUser(page: Page) { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.