-
Notifications
You must be signed in to change notification settings - Fork 78
feat(FR-1014): implement text file editor for NEO File Explorer #4943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a92461d
feat(i18n): add EditFile translation to all locale files
limshyun ca135a0
feat(FileExplorer): add file edit menu item
limshyun a5bca85
fix(FileExplorer): add stopPropagation to prevent event bubbling
limshyun de85aa6
feat(TextFileEditor): add TextFileEditorModal component for editing t…
limshyun 55c6036
feat(TextFileEditor): implement file save functionality
limshyun a15141a
feat(i18n): add EditFile and FailedToLoadFile translations
limshyun ca57b90
feat(FileExplorer): add enableEdit prop to disable edit for non-text …
limshyun 75a47b8
style(TextFileEditor): make modal full width with min-width for code …
limshyun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -4,26 +4,66 @@ import BAIFlex from '../../BAIFlex'; | |||||||
| import useConnectedBAIClient from '../../provider/BAIClientProvider/hooks/useConnectedBAIClient'; | ||||||||
| import { VFolderFile } from '../../provider/BAIClientProvider/types'; | ||||||||
| import { FolderInfoContext } from './BAIFileExplorer'; | ||||||||
| import { MoreOutlined } from '@ant-design/icons'; | ||||||||
| import { useMutation } from '@tanstack/react-query'; | ||||||||
| import { App, Button, theme } from 'antd'; | ||||||||
| import { DownloadIcon } from 'lucide-react'; | ||||||||
| import { App, Button, theme, Dropdown } from 'antd'; | ||||||||
| import { DownloadIcon, EditIcon } from 'lucide-react'; | ||||||||
| import { use } from 'react'; | ||||||||
| import { useTranslation } from 'react-i18next'; | ||||||||
|
|
||||||||
| interface FileItemControlsProps { | ||||||||
| selectedItem: VFolderFile; | ||||||||
| onClickDelete: () => void; | ||||||||
| onClickEdit?: () => void; | ||||||||
| enableDownload?: boolean; | ||||||||
| enableDelete?: boolean; | ||||||||
| enableEdit?: boolean; | ||||||||
| downloadButtonProps?: BAIButtonProps; | ||||||||
| deleteButtonProps?: BAIButtonProps; | ||||||||
| } | ||||||||
|
|
||||||||
| const TEXT_FILE_EXTENSIONS = [ | ||||||||
| '.txt', | ||||||||
| '.md', | ||||||||
| '.json', | ||||||||
| '.yaml', | ||||||||
| '.yml', | ||||||||
| '.xml', | ||||||||
| '.csv', | ||||||||
| '.js', | ||||||||
| '.ts', | ||||||||
| '.jsx', | ||||||||
| '.tsx', | ||||||||
| '.py', | ||||||||
| '.sh', | ||||||||
| '.bash', | ||||||||
| '.html', | ||||||||
| '.css', | ||||||||
| '.scss', | ||||||||
| '.less', | ||||||||
| '.sql', | ||||||||
| '.log', | ||||||||
| '.env', | ||||||||
| '.conf', | ||||||||
| '.config', | ||||||||
| '.ini', | ||||||||
| '.toml', | ||||||||
| ]; | ||||||||
|
|
||||||||
| const isTextFile = (fileName: string): boolean => { | ||||||||
| const lastDotIndex = fileName.lastIndexOf('.'); | ||||||||
| if (lastDotIndex === -1) return false; | ||||||||
| const ext = fileName.toLowerCase().slice(lastDotIndex); | ||||||||
| return TEXT_FILE_EXTENSIONS.includes(ext); | ||||||||
| }; | ||||||||
|
|
||||||||
| const FileItemControls: React.FC<FileItemControlsProps> = ({ | ||||||||
| selectedItem, | ||||||||
| onClickDelete, | ||||||||
| onClickEdit, | ||||||||
| enableDownload = false, | ||||||||
| enableDelete = false, | ||||||||
| enableEdit = false, | ||||||||
| downloadButtonProps, | ||||||||
| deleteButtonProps, | ||||||||
| }) => { | ||||||||
|
|
@@ -108,6 +148,37 @@ const FileItemControls: React.FC<FileItemControlsProps> = ({ | |||||||
| }} | ||||||||
| {...deleteButtonProps} | ||||||||
| /> | ||||||||
| <Dropdown | ||||||||
| menu={{ | ||||||||
| items: [ | ||||||||
| { | ||||||||
| key: 'fileEdit', | ||||||||
| icon: <EditIcon size={14} />, | ||||||||
| label: t('comp:FileExplorer.EditFile'), | ||||||||
| disabled: | ||||||||
| !enableEdit || | ||||||||
| selectedItem.type === 'DIRECTORY' || | ||||||||
| !isTextFile(selectedItem.name), | ||||||||
| onClick: (e) => { | ||||||||
| e.domEvent.stopPropagation(); | ||||||||
| onClickEdit?.(); | ||||||||
| }, | ||||||||
| }, | ||||||||
| ], | ||||||||
| }} | ||||||||
| trigger={['click']} | ||||||||
| > | ||||||||
| <Button | ||||||||
| type="text" | ||||||||
| size="small" | ||||||||
| onClick={(e) => { | ||||||||
| e.preventDefault(); | ||||||||
| e.stopPropagation(); | ||||||||
| }} | ||||||||
| icon={<MoreOutlined />} | ||||||||
|
||||||||
| icon={<MoreOutlined />} | |
| icon={<MoreOutlined />} | |
| aria-label={t('comp:FileExplorer.MoreOptions')} |
Comment on lines
+151
to
+181
Copilot
AI
Jan 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The More menu dropdown currently only has one item (Edit). Consider whether a dropdown is necessary for a single action, or if this is preparation for future menu items. If it's just for the Edit action, a simpler icon button might be more appropriate. If more actions are planned, this is acceptable.
2 changes: 1 addition & 1 deletion
2
packages/backend.ai-ui/src/components/provider/BAIClientProvider/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| export { default as BAIClientProvider } from './BAIClientProvider'; | ||
| export type { BAIClientProviderProps } from './BAIClientProvider'; | ||
| export { BAIClientContext, BAIAnonymousClientContext } from './context'; | ||
| export type { BAIClient } from './types'; | ||
| export type { BAIClient, VFolderFile } from './types'; | ||
| export { default as useConnectedBAIClient } from './hooks/useConnectedBAIClient'; | ||
| export { default as useAnonymousBAIClient } from './hooks/useAnonymousBAIClient'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TEXT_FILE_EXTENSIONS array is defined within the component file but could be shared across the codebase. Consider extracting this to a constants file or utility module, especially since the file type detection logic might be useful elsewhere in the application.