fix(FR-1851): show reservoir page without error boundary #4935

agatha197 · 2026-01-05T05:08:38Z

Remove limit and offset from total(artifacts) query to resolve issue's error.
Update graphql schema.
Update deprecated antd props (valueStyle).

Checklist:

Documentation
Minium required manager version
Specific setting for review (eg., KB link, endpoint or how to setup)
Minimum requirements to check during review
Test case(s) to demonstrate the difference of before/after

agatha197 · 2026-01-05T05:08:56Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-01-05T05:10:32Z

Coverage report for `./packages/backend.ai-ui`

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	63.5%	254/400
🔴	Branches	42.3%	151/357
🔴	Functions	50%	46/92
🟡	Lines	65.16%	230/353

Test suite run success

186 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 4507e03

github-actions · 2026-01-05T05:11:08Z

Coverage report for `./react`

St.^❔	Category	Percentage	Covered / Total
🔴	Statements	4.9% (+0% 🔼)	587/11984
🔴	Branches	4.47% (-0% 🔻)	377/8429
🔴	Functions	2.75%	101/3675
🔴	Lines	4.73% (+0% 🔼)	553/11703

Test suite run success

173 tests passing in 13 suites.

Report generated by 🧪jest coverage report action from 4507e03

Copilot

Pull request overview

This PR resolves an error boundary issue on the Reservoir page by making GraphQL query parameters optional and removing limit/offset from the total artifacts count query. The changes align with a backend API update that allows fetching total artifact counts without pagination parameters.

Key Changes:

Feature flag for reservoir moved from manager version 25.12.0 to 25.14.0
GraphQL query parameters (limit, offset, filter) changed from required to optional
Total artifacts query no longer passes limit/offset parameters
Deprecated Ant Design valueStyle prop replaced with styles object
Added 'use memo' directive for React Compiler optimization

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/lib/backend.ai-client-esm.ts	Moved reservoir feature flag from version 25.12.0 to 25.14.0 to match actual backend API availability
react/src/pages/ReservoirPage.tsx	Made GraphQL query parameters optional, removed limit/offset from total count query, updated deprecated Ant Design prop, added React Compiler directive, improved type safety with filterOutEmpty
packages/backend.ai-ui/src/components/fragments/BAIArtifactTable.tsx	Removed commented-out code
data/schema.graphql	Updated schema with new types and made query parameters optional to support getting total counts without pagination

react/src/pages/ReservoirPage.tsx

nowgnuesLee

LGTM

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

react/src/pages/ReservoirPage.tsx

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

src/lib/backend.ai-client-esm.ts

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot · 2026-01-08T09:33:23Z

react/src/pages/ReservoirPage.tsx

            onClickPull={(artifactId: string, revisionId: string) => {
              artifacts.edges.forEach((artifact) => {
                if (artifact.node.id === artifactId) {


Inconsistent nullable handling. While line 381-383 correctly uses optional chaining e?.node and filterOutEmpty to handle nullable nodes, line 385 in the event handler uses artifact.node.id directly without null checks. This inconsistency could lead to runtime errors if edges contain nullable nodes.

Since the GraphQL query now has nullable parameters, the edges may contain null nodes. Consider applying the same defensive approach throughout, or filter nulls before passing to event handlers.

Copilot AI review requested due to automatic review settings January 5, 2026 05:08

github-actions bot assigned agatha197 Jan 5, 2026

github-actions bot added the size:XL 500~ LoC label Jan 5, 2026

Copilot started reviewing on behalf of agatha197 January 5, 2026 05:09 View session

agatha197 requested review from nowgnuesLee and yomybaby and removed request for Copilot January 5, 2026 05:11

agatha197 marked this pull request as draft January 5, 2026 05:14

agatha197 force-pushed the fix_FR-1851_/reservoir-page-error branch from d695012 to 174cab3 Compare January 5, 2026 05:20

github-actions bot added area:lib Library and SDK related issue. 벤처리움 labels Jan 5, 2026

agatha197 marked this pull request as ready for review January 5, 2026 05:20

Copilot AI review requested due to automatic review settings January 5, 2026 05:20

Copilot started reviewing on behalf of agatha197 January 5, 2026 05:20 View session

Copilot AI reviewed Jan 5, 2026

View reviewed changes

react/src/pages/ReservoirPage.tsx Show resolved Hide resolved

agatha197 mentioned this pull request Jan 6, 2026

feat(FR-1850): Add Hugging Face model import functionality with folder creation support #4945

Open

5 tasks

agatha197 force-pushed the fix_FR-1851_/reservoir-page-error branch from 174cab3 to ae20552 Compare January 6, 2026 08:25

nowgnuesLee approved these changes Jan 7, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 7, 2026 10:20

agatha197 force-pushed the fix_FR-1851_/reservoir-page-error branch from ae20552 to 9fb1e60 Compare January 7, 2026 10:20

Copilot started reviewing on behalf of agatha197 January 7, 2026 10:21 View session

agatha197 force-pushed the fix_FR-1851_/reservoir-page-error branch from 9fb1e60 to 325b9e6 Compare January 7, 2026 10:22

Copilot AI reviewed Jan 7, 2026

View reviewed changes

react/src/pages/ReservoirPage.tsx Show resolved Hide resolved

agatha197 changed the base branch from main to graphite-base/4935 January 8, 2026 04:20

agatha197 force-pushed the fix_FR-1851_/reservoir-page-error branch from 325b9e6 to 5e01a45 Compare January 8, 2026 04:20

agatha197 changed the base branch from graphite-base/4935 to feat/create-BAIVFolderSelect January 8, 2026 04:20

agatha197 mentioned this pull request Jan 8, 2026

feat(FR-1870): Create BAIVFolderSelect using usePaginationFragment #4947

Open

5 tasks

agatha197 force-pushed the fix_FR-1851_/reservoir-page-error branch from 5e01a45 to 705732f Compare January 8, 2026 05:16

Copilot AI review requested due to automatic review settings January 8, 2026 05:16

Copilot started reviewing on behalf of agatha197 January 8, 2026 05:16 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

src/lib/backend.ai-client-esm.ts Show resolved Hide resolved

nowgnuesLee changed the base branch from feat/create-BAIVFolderSelect to graphite-base/4935 January 8, 2026 06:10

agatha197 force-pushed the fix_FR-1851_/reservoir-page-error branch from 705732f to ad64b31 Compare January 8, 2026 06:37

agatha197 force-pushed the graphite-base/4935 branch from c888801 to 8ccc994 Compare January 8, 2026 06:37

agatha197 changed the base branch from graphite-base/4935 to feat/create-BAIVFolderSelect January 8, 2026 06:37

Copilot AI review requested due to automatic review settings January 8, 2026 09:29

yomybaby force-pushed the fix_FR-1851_/reservoir-page-error branch from ad64b31 to bf4c404 Compare January 8, 2026 09:29

yomybaby force-pushed the feat/create-BAIVFolderSelect branch from 8ccc994 to 1f8120a Compare January 8, 2026 09:29

Copilot started reviewing on behalf of yomybaby January 8, 2026 09:29 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

nowgnuesLee changed the base branch from feat/create-BAIVFolderSelect to graphite-base/4935 January 9, 2026 06:52

fix(FR-1851): show reservoir page without error boundary

4507e03

agatha197 force-pushed the fix_FR-1851_/reservoir-page-error branch from bf4c404 to 4507e03 Compare January 9, 2026 07:17

agatha197 force-pushed the graphite-base/4935 branch from 1f8120a to 922a8c7 Compare January 9, 2026 07:17

agatha197 changed the base branch from graphite-base/4935 to feat/create-BAIVFolderSelect January 9, 2026 07:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(FR-1851): show reservoir page without error boundary #4935

fix(FR-1851): show reservoir page without error boundary #4935

agatha197 commented Jan 5, 2026 •

edited

Loading

Uh oh!

agatha197 commented Jan 5, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 5, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

nowgnuesLee left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(FR-1851): show reservoir page without error boundary #4935

Are you sure you want to change the base?

fix(FR-1851): show reservoir page without error boundary #4935

Conversation

agatha197 commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agatha197 commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report for ./packages/backend.ai-ui

Test suite run success

Uh oh!

github-actions bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report for ./react

Test suite run success

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

nowgnuesLee left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

agatha197 commented Jan 5, 2026 •

edited

Loading

agatha197 commented Jan 5, 2026 •

edited

Loading

github-actions bot commented Jan 5, 2026 •

edited

Loading

Coverage report for `./packages/backend.ai-ui`

github-actions bot commented Jan 5, 2026 •

edited

Loading

Coverage report for `./react`