fix: take schema from reader instead of builder#811
Open
Droeftoeter wants to merge 1 commit intokylebarron:mainfrom
Open
fix: take schema from reader instead of builder#811Droeftoeter wants to merge 1 commit intokylebarron:mainfrom
Droeftoeter wants to merge 1 commit intokylebarron:mainfrom
Conversation
|
Owner
|
Thanks! Would you be able to add a JS test that failed before this change but passes after it? I figure just passing a column projection into a read function should test this code path |
|
Any movements on getting this merged in? Just ran into this issue myself today. |
Owner
|
Ideally I'd like a simple test for this just to ensure we don't regress in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fetching a subset of columns the full schema was returned, now it returns the projected schema instead.
Fixes #810