MTV-3741 part 1 - Make test compatible with provider creation form changes #2178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pedro-S-Abreu
changed the title
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2178 +/- ##
===========================================
- Coverage 36.81% 14.09% -22.72%
===========================================
Files 158 1031 +873
Lines 2548 19098 +16550
Branches 599 3887 +3288
===========================================
+ Hits 938 2692 +1754
- Misses 1428 15763 +14335
- Partials 182 643 +461 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pedro-S-Abreu
force-pushed
the
test-enhance-create-provider-form-1
branch
3 times, most recently
from
269743e to
7c0056a
Compare
Pedro-S-Abreu
changed the title
Collaborator
Author
|
/retest |
- Update CreateProviderPage selectors for new form structure - Add provider-specific field methods (vSphere, OVA, OVirt) - Parametrize provider creation tests using test scenarios - Update StorageMapStep to correctly parse source storage column - Update test data for current environment Resolves: MTV-3741 Signed-off-by: Pedro Abreu <[email protected]>
Pedro-S-Abreu
force-pushed
the
test-enhance-create-provider-form-1
branch
from
7c0056a to
a004390
Compare
avivtur
reviewed
Jan 12, 2026
| expect(providerResource).not.toBeNull(); | ||
| expect(providerResource?.spec?.type).toBe(providerType); | ||
|
|
||
| if (testProviderData.useVddkAioOptimization === true) { |
Collaborator
There was a problem hiding this comment.
if (testProviderData.useVddkAioOptimization)
avivtur
reviewed
Jan 12, 2026
|
|
||
| if (testProviderData.useVddkAioOptimization === true) { | ||
| expect(providerResource?.spec?.settings?.useVddkAioOptimization).toBe('true'); | ||
| } else if (testProviderData.useVddkAioOptimization === false) { |
Collaborator
There was a problem hiding this comment.
no need else can be if (!testProviderData.useVddkAioOptimization)
avivtur
reviewed
Jan 12, 2026
| expect(providerResource?.spec?.settings?.useVddkAioOptimization).toBe('true'); | ||
| }, | ||
| ); | ||
| const providerTestScenarios: ProviderTestScenario[] = [ |
Collaborator
There was a problem hiding this comment.
worth extracting to a constant to make this file a bit more clear and to easily expand more scenrios
Resolves: MTV-3741 Signed-off-by: Pedro Abreu <[email protected]>
Collaborator
Author
|
/retest |
Resolves: None Signed-off-by: Pedro Abreu <[email protected]>
|
Collaborator
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MTV-3741
📝 Links
https://issues.redhat.com/browse/MTV-3741
📝 Description
🎥 Demo
📝 CC://