Skip to content

Conversation

@BenTheElder
Copy link
Member

/cc @stmcginnis @aojea

note: more generally we are careful to keep these relatively in sync with kubernetes/kubernetes, and to try changes in the "-canary" job before filtering them into both repos

I specially ensured when forking the job here that we didn't need to repeat #34673, by checking the pull-kubernetes-e2e-kind job for 1.33

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/jobs labels Apr 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 13, 2025
@stmcginnis
Copy link
Contributor

Looks correct to me.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 285aa7b into kubernetes:master Apr 14, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kind-presubmits.yaml using file config/jobs/kubernetes-sigs/kind/kind-presubmits.yaml
Details

In response to this:

/cc @stmcginnis @aojea

note: more generally we are careful to keep these relatively in sync with kubernetes/kubernetes, and to try changes in the "-canary" job before filtering them into both repos

I specially ensured when forking the job here that we didn't need to repeat #34673, by checking the pull-kubernetes-e2e-kind job for 1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants