Skip to content

[releng] 1.33: Update kubekins-e2e variants.yaml with 1.33 config #34651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

jimangel
Copy link
Member

@jimangel jimangel commented Apr 8, 2025

Update kubekins-e2e variant with 1.33 config.

/sig release
/area release-eng
/hold

cc @kubernetes/release-engineering @mbianchidev

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/images sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 8, 2025
@k8s-ci-robot k8s-ci-robot requested a review from puerco April 8, 2025 15:40
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 8, 2025
@dims
Copy link
Member

dims commented Apr 8, 2025

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2025
@jimangel
Copy link
Member Author

jimangel commented Apr 9, 2025

/unhold

edit: now that 1.33 branch is created (after complete rc release)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit f52ea67 into kubernetes:master Apr 9, 2025
5 checks passed
@jimangel
Copy link
Member Author

Ref: kubernetes/sig-release#2755

@BenTheElder
Copy link
Member

follow up: #34672

we probably need to add a step to handle this automatically, we necessarily have to bump to the latest images to get the new branch if we only recently added it to variants, but we also don't necessarily want to aggressively bump the other branches to the latest builds

@BenTheElder
Copy link
Member

#34675 to track mitigation options for 1.34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants