Skip to content

docs: Fix instructions for building iso #20830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Conversation

nirs
Copy link
Contributor

@nirs nirs commented May 24, 2025

Testing shows that we need changes changes:

  • x86_64 cpu
  • Ubuntu 22.04
  • docker is required even if building without docker
  • python2 instead of python
  • genisoimage (for mkisofs)
  • Installing Go manually (Ubuntu 22.04 have only Go 1.18)
  • Target should be minikube-iso-aarch64 or minikube-iso-x86_64. Using
    arm64 and amd64 fails.

I also cleaned up a little bit the formatting to make it easier to
maintain (one package per line).

Tested building:

  • minikube-iso-aarch64
  • minikube-iso-x86_64

I tests only the arm64 iso image.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 24, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 24, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @nirs. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 24, 2025
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@nirs nirs force-pushed the docs-build-iso branch 3 times, most recently from 13d3505 to 44c5bc2 Compare May 24, 2025 18:19
Testing shows that we need changes changes:
- x86_64 cpu
- Ubuntu 22.04
- docker is required even if building without docker
- python2 instead of python
- genisoimage (for mkisofs)
- Installing Go manually (Ubuntu 22.04 have only Go 1.18)
- Target should be minikube-iso-aarch64 or minikube-iso-x86_64. Using
  arm64 and amd64 fails.

I also cleaned up a little bit the formatting to make it easier to
maintain (one package per line).

Tested building:
- minikube-iso-aarch64
- minikube-iso-x86_64

I did not test the built iso images.
@nirs nirs force-pushed the docs-build-iso branch from 44c5bc2 to ec2b7c1 Compare May 24, 2025 20:23
@nirs nirs changed the title docs: Add missing details for iso build doc docs: docs: Fix instructions for building iso May 24, 2025
@nirs nirs marked this pull request as ready for review May 24, 2025 20:41
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 24, 2025
@k8s-ci-robot k8s-ci-robot requested review from medyagh and spowelljr May 24, 2025 20:41
@nirs nirs changed the title docs: docs: Fix instructions for building iso docs: Fix instructions for building iso May 27, 2025
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for updating this doc, been a long time since touched

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2025
@medyagh
Copy link
Member

medyagh commented May 27, 2025

/lgtm

@medyagh medyagh merged commit c306a0f into kubernetes:master May 27, 2025
5 of 6 checks passed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, nirs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nirs nirs deleted the docs-build-iso branch May 27, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants