-
Notifications
You must be signed in to change notification settings - Fork 5k
docs: Fix instructions for building iso #20830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @nirs. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Can one of the admins verify this patch? |
13d3505
to
44c5bc2
Compare
Testing shows that we need changes changes: - x86_64 cpu - Ubuntu 22.04 - docker is required even if building without docker - python2 instead of python - genisoimage (for mkisofs) - Installing Go manually (Ubuntu 22.04 have only Go 1.18) - Target should be minikube-iso-aarch64 or minikube-iso-x86_64. Using arm64 and amd64 fails. I also cleaned up a little bit the formatting to make it easier to maintain (one package per line). Tested building: - minikube-iso-aarch64 - minikube-iso-x86_64 I did not test the built iso images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for updating this doc, been a long time since touched
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, nirs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Testing shows that we need changes changes:
arm64 and amd64 fails.
I also cleaned up a little bit the formatting to make it easier to
maintain (one package per line).
Tested building:
I tests only the arm64 iso image.