Use preload image for worker nodes

[Diff-fusion]

Currently when creating a worker node it will not be filled with any container images.
So it will pull the required images from the upstream registry.
This makes it impossible to use a multi node cluster in an offline environment.
This PR will changes the behavior to also copy the preload image to worker nodes.

Log before this patch: without-preload.log
Log after this patch: with-preload.log

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Diff-fusion (a6f2043, 640f5c0)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Diff-fusion
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @Diff-fusion!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Diff-fusion. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

good catch ! I didnt know our multinode was not using preload.
thank you for this PR do you mind pasting in the PR description Before And After this PR, (--alsologtostderr with verbose logs to see this is working) ?

and also we should also add this to our multi node integration test

[medyagh]

/ok-to-test

[medyagh]

@Diff-fusion would you be interested to add a small test to the multi node test?

minikube/test/integration/multinode_test.go

Line 39 in 3332297

func TestMultiNode(t *testing.T) {

you could check for the Log line in the worker nodes for using the preload ?

[medyagh]

@ComradeProgrammer can you plz check this PR to verify it is correct

[Diff-fusion]

I attached the logs from before and after this change to the initial comment. Also I changed the error behavior to just log a message instead of failing the start. This seems more reasonable here.
Regarding the test: Should I check the logs in the existing validateMultiNodeStart or create a new test case which adds another node to the cluster? Or is there some way to access the log of a previous case from a later one?

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20470) |
+----------------+----------+---------------------+
| minikube start | 49.6s    | 50.4s               |
| enable ingress | 16.1s    | 15.2s               |
+----------------+----------+---------------------+

Details

Times for minikube start: 47.8s 47.8s 51.3s 50.4s 50.7s
Times for minikube (PR 20470) start: 50.1s 48.6s 50.6s 49.1s 53.4s

Times for minikube ingress: 15.0s 15.5s 19.0s 14.5s 16.6s
Times for minikube (PR 20470) ingress: 15.5s 15.0s 16.1s 15.0s 14.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20470) |
+----------------+----------+---------------------+
| minikube start | 22.6s    | 21.0s               |
| enable ingress | 12.4s    | 12.0s               |
+----------------+----------+---------------------+

Details

Times for minikube (PR 20470) start: 21.1s 21.4s 21.0s 20.2s 21.2s
Times for minikube start: 21.8s 23.6s 21.1s 24.1s 22.5s

Times for minikube (PR 20470) ingress: 12.3s 10.2s 12.3s 12.8s 12.2s
Times for minikube ingress: 12.2s 12.3s 12.7s 12.3s 12.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20470) |
+----------------+----------+---------------------+
| minikube start | 20.5s    | 20.7s               |
| enable ingress | 32.5s    | 29.3s               |
+----------------+----------+---------------------+

Details

Times for minikube ingress: 38.8s 23.2s 22.7s 39.2s 38.8s
Times for minikube (PR 20470) ingress: 38.2s 22.8s 38.8s 23.3s 23.3s

Times for minikube start: 20.4s 19.8s 19.8s 19.9s 22.3s
Times for minikube (PR 20470) start: 19.2s 19.6s 22.2s 22.5s 20.0s

[minikube-pr-bot]

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment	Test Name	Flake Rate
Docker_Linux_containerd (1 failed)	TestPreload(gopogh)	0.00% (chart)
Docker_Linux_docker_arm64 (1 failed)	TestStartStop/group/old-k8s-version/serial/SecondStart(gopogh)	0.00% (chart)

Besides the following environments also have failed tests:

• Docker_Linux_crio_arm64: 24 failed (gopogh)

• Docker_Cloud_Shell: 3 failed (gopogh)

• Docker_Linux_crio: 1 failed (gopogh)

• KVM_Linux_crio: 21 failed (gopogh)

• Hyper-V_Windows: 11 failed (gopogh)

• Docker_Linux_containerd_arm64: 1 failed (gopogh)

To see the flake rates of all tests by environment, click here.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.