Skip to content

Add ClusterSecretStore for IBM provider's Secrets Manager #7904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2025
Merged

Add ClusterSecretStore for IBM provider's Secrets Manager #7904

merged 1 commit into from
Mar 22, 2025

Conversation

Rajalakshmi-Girish
Copy link
Contributor

This ClusterSecretStore is to fetch the secrets from Secrets Manager in IBM Cloud provider.
This would be deployed on IBM's ppc64le build cluster added by #7862

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 20, 2025
@k8s-ci-robot k8s-ci-robot added area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 20, 2025
mkumatag
mkumatag suggested changes Mar 20, 2025
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope will have external secrets also created soon to pull the keys from the secret manager.

@mkumatag
Copy link
Member

/cc @upodroid

@k8s-ci-robot k8s-ci-robot requested a review from upodroid March 20, 2025 12:39
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 20, 2025
@Rajalakshmi-Girish Rajalakshmi-Girish force-pushed the ibm-sm branch 2 times, most recently from 3b349b4 to 2fde88c Compare March 20, 2025 14:32
mkumatag
mkumatag suggested changes Mar 20, 2025
View reviewed changes
mkumatag
mkumatag approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2025
@mkumatag
Copy link
Member

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims March 22, 2025 04:29
@dims
Copy link
Member

dims commented Mar 22, 2025

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, mkumatag, Rajalakshmi-Girish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1371c77 into kubernetes:main Mar 22, 2025
3 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Mar 22, 2025
@mkumatag
Copy link
Member

@upodroid post merging this change, I don't see the clustersecretstores or external secret, so do we need to deploy them manually or some automation will take care of this?

@upodroid upodroid mentioned this pull request Mar 22, 2025
Merged
@upodroid
Copy link
Member

Automation will take care of it but there something was wrong, fixed in 7914

@mkumatag
Copy link
Member

mkumatag commented Mar 22, 2025 •
edited
Loading

Automation will take care of it but there something was wrong, fixed in 7914

ah, okay. How to avoid such errors? do we have any instructions or guidelines how to add these new resources and is there way to run dry-run commands to validate the specs?

@Rajalakshmi-Girish Rajalakshmi-Girish mentioned this pull request Apr 1, 2025
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@michelle192837 michelle192837 Awaiting requested review from michelle192837

@xmcqueen xmcqueen Awaiting requested review from xmcqueen

@upodroid upodroid Awaiting requested review from upodroid

@dims dims Awaiting requested review from dims

Assignees

@dims dims

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
5 participants
@Rajalakshmi-Girish @mkumatag @dims @k8s-ci-robot @upodroid