Skip to content

tests: add simple e2e test for guestbook#595

Open
justinsb wants to merge 1 commit into
kubernetes:masterfrom
justinsb:e2e_test_for_guestbook
Open

tests: add simple e2e test for guestbook#595
justinsb wants to merge 1 commit into
kubernetes:masterfrom
justinsb:e2e_test_for_guestbook

Conversation

@justinsb

@justinsb justinsb commented Jul 7, 2026

Copy link
Copy Markdown
Member

This highlights a few issues (out of date images, etc.),
and will allow us to fix them with test coverage.

@kubernetes-prow kubernetes-prow Bot requested review from janetkuo and soltysh July 7, 2026 22:12
@kubernetes-prow kubernetes-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 7, 2026
@soltysh

soltysh commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@justinsb any particular reason for a gh workflow, rather than just hooking this up to prow?

@justinsb

justinsb commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

@justinsb any particular reason for a gh workflow, rather than just hooking this up to prow?

I was just being lazy. Sent kubernetes/test-infra#37422 to add some prow.

Created a single entrypoint though, rather than having to go back and forth to prow config e.g. if we add a test for guestbook-go. Should also let us share a cluster between examples, which should be slightly faster.

@soltysh soltysh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold
until we land kubernetes/test-infra#37422

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2026
@kubernetes-prow kubernetes-prow Bot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 10, 2026
@soltysh

soltysh commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

/retest

Comment thread tests/e2e/e2e-kind
@@ -0,0 +1,47 @@
#!/usr/bin/env bash

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soltysh

soltysh commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

/lgtm cancel

@kubernetes-prow kubernetes-prow Bot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2026
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justinsb
Once this PR has been reviewed and has the lgtm label, please ask for approval from soltysh. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2026
This highlights a few issues (out of date images, etc.),
and will allow us to fix them with test coverage.
@justinsb justinsb force-pushed the e2e_test_for_guestbook branch from bc0fd84 to 863626b Compare July 10, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants