tests: add simple e2e test for guestbook#595
Conversation
|
@justinsb any particular reason for a gh workflow, rather than just hooking this up to prow? |
22ddd5c to
bc0fd84
Compare
I was just being lazy. Sent kubernetes/test-infra#37422 to add some prow. Created a single entrypoint though, rather than having to go back and forth to prow config e.g. if we add a test for guestbook-go. Should also let us share a cluster between examples, which should be slightly faster. |
soltysh
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/hold
until we land kubernetes/test-infra#37422
|
/retest |
| @@ -0,0 +1,47 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
You need to change the script to match what we have in https://github.com/kubernetes/test-infra/blob/06525d81d9d588c8064d4ecd0483b03d3497fc81/config/jobs/kubernetes/examples/examples-presubmits.yaml#L22 which is test/e2e/e2e-kind
|
/lgtm cancel |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This highlights a few issues (out of date images, etc.), and will allow us to fix them with test coverage.
bc0fd84 to
863626b
Compare
This highlights a few issues (out of date images, etc.),
and will allow us to fix them with test coverage.