Skip to content

Automated cherry pick of #1332: feat(ecr-cred-provider): support public dualstack endpoints#1346

Merged
k8s-ci-robot merged 1 commit intokubernetes:release-1.33from
mselim00:automated-cherry-pick-of-#1332-upstream-release-1.33
Mar 4, 2026
Merged

Automated cherry pick of #1332: feat(ecr-cred-provider): support public dualstack endpoints#1346
k8s-ci-robot merged 1 commit intokubernetes:release-1.33from
mselim00:automated-cherry-pick-of-#1332-upstream-release-1.33

Conversation

@mselim00
Copy link
Contributor

@mselim00 mselim00 commented Mar 3, 2026

Cherry pick of #1332 on release-1.33.

#1332: feat(ecr-cred-provider): support public dualstack endpoints

For details on the cherry pick process, see the cherry pick requests page.


@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 3, 2026
@k8s-ci-robot k8s-ci-robot requested a review from dims March 3, 2026 18:54
@k8s-ci-robot k8s-ci-robot added the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Mar 3, 2026
@k8s-ci-robot k8s-ci-robot requested a review from nckturner March 3, 2026 18:55
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 3, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @mselim00. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mselim00 mselim00 force-pushed the automated-cherry-pick-of-#1332-upstream-release-1.33 branch from 9f01824 to 6b96730 Compare March 3, 2026 18:56
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mselim00
Copy link
Contributor Author

mselim00 commented Mar 3, 2026

/cc @kmala

@k8s-ci-robot k8s-ci-robot requested a review from kmala March 3, 2026 19:34
@mselim00
Copy link
Contributor Author

mselim00 commented Mar 3, 2026

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 3, 2026
@kmala
Copy link
Member

kmala commented Mar 3, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 3, 2026
@mselim00 mselim00 force-pushed the automated-cherry-pick-of-#1332-upstream-release-1.33 branch from 6b96730 to 907e04d Compare March 3, 2026 23:08
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 3, 2026
@mselim00
Copy link
Contributor Author

mselim00 commented Mar 3, 2026

/retest

@kmala
Copy link
Member

kmala commented Mar 4, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2026
@k8s-ci-robot k8s-ci-robot merged commit 4164cbc into kubernetes:release-1.33 Mar 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants