-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix: fix remote error: tls: internal error
#1522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dongjiang1989
wants to merge
9
commits into
kubernetes-sigs:master
Choose a base branch
from
dongjiang1989:fix-tlsconfig
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6
−0
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e90c23d
fix tls bug
dongjiang1989 3aecde0
update by codereview
dongjiang1989 367331f
Merge branch 'kubernetes-sigs:master' into fix-tlsconfig
dongjiang1989 601521b
update kubelet_client
dongjiang1989 4b0bb66
fix unittest case
dongjiang1989 b4d69e1
fix unittest case
dongjiang1989 3db8410
mistake
dongjiang1989 5c78454
Merge branch 'kubernetes-sigs:master' into fix-tlsconfig
dongjiang1989 f177167
Merge branch 'kubernetes-sigs:master' into fix-tlsconfig
dongjiang1989 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should proceed with this change. Kubelet supports http/2 by default, so it would be more efficient to have http/2 over http/1.1 by default.
But if this solves the reported issue, could it be that EKS LB needs to be configured by users to supports http/2?