Add testing exclude resource prefixes #7492
Open
+299
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kannon92 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
cncf-cla: yes
mbobrovskyi
reviewed
Nov 3, 2025
test/integration/singlecluster/scheduler/excluderesources/scheduler_test.go
Outdated
Show resolved
Hide resolved
mbobrovskyi
reviewed
Nov 3, 2025
test/integration/singlecluster/scheduler/excluderesources/scheduler_test.go
Outdated
Show resolved
Hide resolved
mbobrovskyi
reviewed
Nov 3, 2025
test/integration/singlecluster/scheduler/excluderesources/scheduler_test.go
Outdated
Show resolved
Hide resolved
mbobrovskyi
reviewed
Nov 3, 2025
test/integration/singlecluster/scheduler/excluderesources/scheduler_test.go
Outdated
Show resolved
Hide resolved
mbobrovskyi
reviewed
Nov 3, 2025
test/integration/singlecluster/scheduler/excluderesources/scheduler_test.go
Outdated
Show resolved
Hide resolved
mbobrovskyi
reviewed
Nov 3, 2025
test/integration/singlecluster/scheduler/excluderesources/scheduler_test.go
Outdated
Show resolved
Hide resolved
mbobrovskyi
reviewed
Nov 3, 2025
test/integration/singlecluster/scheduler/excluderesources/scheduler_test.go
Outdated
Show resolved
Hide resolved
mbobrovskyi
reviewed
Nov 3, 2025
test/integration/singlecluster/scheduler/excluderesources/scheduler_test.go
Outdated
Show resolved
Hide resolved
mbobrovskyi
reviewed
Nov 3, 2025
test/integration/singlecluster/scheduler/excluderesources/scheduler_test.go
Outdated
Show resolved
Hide resolved
mbobrovskyi
reviewed
Nov 3, 2025
test/integration/singlecluster/scheduler/excluderesources/scheduler_test.go
Outdated
Show resolved
Hide resolved
kannon92
force-pushed
the
add-testing-exclude-resource-prefixes
branch
from
acc2be2 to
481c202
Compare
…tion This adds comprehensive integration tests for the excludeResourcePrefixes feature in a dedicated test directory following the pattern of other scheduler tests (fairsharing, podsready). The tests verify: - Basic resource exclusion from quota calculations - Multiple excluded resource prefixes - Quota enforcement for non-excluded resources - Exact prefix matching (not substring matching) All tests create Workload objects directly and use the scheduler test utilities for robust assertions.
kannon92
force-pushed
the
add-testing-exclude-resource-prefixes
branch
from
481c202 to
c5318b2
Compare
|
@kannon92: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Add test cases for scheduler for excludeResourcePrefixes.
As I was working on #5800, I notice we don't really have a good test coverage of this excludeResourcePrefixes in the configuration.
There is one test in pod_controller in this but I think it make sense to have this for the scheduler.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Assisted by Claude Code
Does this PR introduce a user-facing change?