don't update PodsReady condition timely

[olderTaoist]

What type of PR is this?

/kind bug

What this PR does / why we need it:

JobReconciler don't update PodsReady condition timely when updata status failed. no event triggers reconcile, need manually trigger the workload update.

Which issue(s) this PR fixes:

Fixes #7363

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Requeue generic job when update workload's podsready condition fail.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	be888bd
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/690aa86da6d17c0007ac4103

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olderTaoist
Once this PR has been reviewed and has the lgtm label, please assign mimowo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @olderTaoist!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @olderTaoist. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mimowo]

/ok-to-test

[mimowo]

Thank you for the fix, lgtm, but can you think of adding a test for it?

[mimowo]

Please also update the "Does this PR introduce a user-facing change?" section to describe the fix. It will land in release notes for users.

[mimowo]

cc @PBundyra ptal

[olderTaoist]

Thank you for the fix, lgtm, but can you think of adding a test for it?

let me think about how to write a single test. I also accidentally discovered that in our k8s environment, accessing the webhook through the service (kube-proxy) failed probabilistically, resulting in the PodReady status not being updated timely and subsequent tasks being unable to be scheduled.

[PBundyra]

Suggested change

	return ctrl.Result{
	RequeueAfter: 0,
	}, err
	return ctrl.Result{}, client.IgnoreNotFound(err)

[olderTaoist]

Done as you saied. because my use case is that when a job's podready status is false (no timeout), it will block all subsequent jobs, i wanted the Reconciler to reconcile immediately, so I didn't use the default behavior of controller-runtime.

[PBundyra]

IIUC, the return ctrl.Result{}, client.IgnoreNotFound(err) will make reconciler requeue the request right away. Am I missing something?

[olderTaoist]

when Reconcile return error, controller-runtime default retry mechanism uses a rate limiter.

[olderTaoist]

Thank you for the fix, lgtm, but can you think of adding a test for it?

Done

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: olderTaoist / name: walker (be888bd)