🐛 (go/v4): Fix Docker builds failing when projects don’t include apis/, controllers/, or webhooks by updating .dockerignore to allow only Go source files and module metadata #5048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
camilamacedo86
changed the title
camilamacedo86
changed the title
camilamacedo86
changed the title
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
improve-dockerignore
branch
from
f493b5d to
e2b6791
Compare
aman4433
reviewed
Aug 27, 2025
| # More info: https://docs.docker.com/engine/reference/builder/#dockerignore-file | ||
| # Ignore build and test binaries. | ||
| bin/ | ||
| # Ignore everything |
Contributor
There was a problem hiding this comment.
Maybe adjust the comment here from # Ignore everything to something like # Ignore everything by default, re-include only needed files to better reflect what the file is doing.
aman4433
reviewed
Aug 27, 2025
Contributor
aman4433
left a comment
aman4433
left a comment
There was a problem hiding this comment.
Overall this looks solid and fixes the bug as intended. 👍
camilamacedo86
force-pushed
the
improve-dockerignore
branch
from
e2b6791 to
ae92a12
Compare
…ontrollers/, or webhooks by updating .dockerignore to allow only Go source files and module metadata The make docker-build command no longer fails for new projects that don't yet have api/ or internal/ directories. What changed: - The Dockerfile now uses a general COPY . . command. - The .dockerignore file has been updated to filter the build context, ensuring only necessary files are included.
camilamacedo86
force-pushed
the
improve-dockerignore
branch
from
ae92a12 to
c2e1e09
Compare
Member
|
LGTM |
camilamacedo86
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5046