🌱 [external-plugin] fix(ci): use Make targets for CLI install and expose plugin failures #4823
+207
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
camilamacedo86
force-pushed
the
external-plugin-fix
branch
from
95356d9 to
912d117
Compare
k8s-ci-robot
added
size/L
camilamacedo86
force-pushed
the
external-plugin-fix
branch
4 times, most recently
from
c4315d6 to
07e20af
Compare
…e plugin failures Previously, CI used inlined shell commands that produced an invalid `kubebuilder` binary, causing cryptic errors like: `/home/runner/.../kubebuilder: line 1: '!<arch>'` This commit switches to official Makefile targets to correctly build and install the Kubebuilder CLI. It also improves local testability and ensures plugin command failures are no longer silently skipped.
camilamacedo86
force-pushed
the
external-plugin-fix
branch
from
07e20af to
cd97195
Compare
camilamacedo86
changed the title
|
I am moving forward here just to unblock the CI. However, we must review this sample plugin. A issue was created for we track the need: #4824 |
camilamacedo86
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…