-
Notifications
You must be signed in to change notification settings - Fork 1.6k
🐛 (helm/v1-alpha): standardized file and directory permissions scaffolding with 0644/0755 #4814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @jtyr! |
Hi @jtyr. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution 🥇
/lgtm
/ok-to-test |
Hi @jtyr Can you please check the lint issue? Also, note that we need to run |
@camilamacedo86 Thank you for reviewing my PR and giving me pointers how to fix the failing checks. I think I have fixed everything so let's see if the checks pass now. |
Hi @jtyr That is amazing 🥇 Could you please:
Then, we will have all in place to make this one get merged !!! |
Signed-off-by: Jiri Tyr <[email protected]>
@camilamacedo86 I have rebased my feature branch and squashed my commits. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, jtyr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is changing file permissions for files and directories that are created by the Helm plugin. The permissions align with permissions of files and directories created by the
kubebuilder
itself for example when it generates manifests in theconfig
directory.