Skip to content

🐛 (helm/v1-alpha): standardized file and directory permissions scaffolding with 0644/0755 #4814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

jtyr
Copy link
Contributor

@jtyr jtyr commented May 22, 2025

This PR is changing file permissions for files and directories that are created by the Helm plugin. The permissions align with permissions of files and directories created by the kubebuilder itself for example when it generates manifests in the config directory.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 22, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @jtyr!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 22, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @jtyr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@camilamacedo86 camilamacedo86 changed the title Non-breaking feature: Unifying dir/file permissions 🐛 (helm/v1-alpha): standardized file and directory permissions scaffolding with 0644/0755 May 24, 2025
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 🥇
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 24, 2025
@camilamacedo86
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 24, 2025
@camilamacedo86 camilamacedo86 removed lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 24, 2025
@camilamacedo86
Copy link
Member

Hi @jtyr

Can you please check the lint issue?

Also, note that we need to run make install and make generate to ensure that we will re-scaffold all files with the changes. Can you please do that so we can move forward with this one?

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2025
@jtyr
Copy link
Contributor Author

jtyr commented May 25, 2025

@camilamacedo86 Thank you for reviewing my PR and giving me pointers how to fix the failing checks. I think I have fixed everything so let's see if the checks pass now.

@camilamacedo86
Copy link
Member

Hi @jtyr

That is amazing 🥇
Thank you for your ocntirbution

Could you please:

  • Rebase with master ( see that is falling because the code is outdated ; sorry for that )
  • Squash the commits ( ideally to ensure a good history we would have 1 PR -> 1 commit -> 1 fix/RFE )

Then, we will have all in place to make this one get merged !!!
Thank you again for your contribution !!
Your help is more than welcome 🎉 .

@jtyr jtyr force-pushed the jtyr-modeperm branch from 3e3e441 to 9fad530 Compare May 25, 2025 23:06
@jtyr
Copy link
Contributor Author

jtyr commented May 25, 2025

@camilamacedo86 I have rebased my feature branch and squashed my commits.

@camilamacedo86
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, jtyr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1281364 into kubernetes-sigs:master May 26, 2025
33 checks passed
@jtyr jtyr deleted the jtyr-modeperm branch May 26, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants