Skip to content

WIP: 🐛 fix: remove command to ignore lll in api/ dir #4780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WIP: 🐛 fix: remove command to ignore lll in api/ dir #4780

wants to merge 1 commit into from
+146 −32

Conversation

camilamacedo86
Copy link
Member

…

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2025
@camilamacedo86 camilamacedo86 force-pushed the remove-ignore-lll-api branch from da08f64 to fd8d411 Compare April 11, 2025 00:40
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 11, 2025
@camilamacedo86 camilamacedo86 force-pushed the remove-ignore-lll-api branch from fd8d411 to fb47951 Compare April 11, 2025 00:46
@camilamacedo86 camilamacedo86 changed the title 🐛 (Follow up of : #4752 - Upgrade GolangCI) - fix: remove command to ignore lll in api/ dir WIP: 🐛 (Follow up of : #4752 - Upgrade GolangCI) - fix: remove command to ignore lll in api/ dir Apr 11, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2025
@camilamacedo86 camilamacedo86 changed the title WIP: 🐛 (Follow up of : #4752 - Upgrade GolangCI) - fix: remove command to ignore lll in api/ dir WIP: 🐛 fix: remove command to ignore lll in api/ dir Apr 11, 2025
@camilamacedo86
Copy link
Member Author

Check after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavinjsir Kavinjsir Awaiting requested review from Kavinjsir

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camilamacedo86 @k8s-ci-robot